database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-4801 Replace Row methods getStringLength() and getStringPointer() to getConstString()

Browse Source
This commit is contained in:
Alexander Barkov
2021-07-06 21:15:32 +04:00
parent b9bd207d3b
commit 9794f24369
13 changed files with 73 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
utils/rowgroup/rowaggregation.cpp
View File

@ -388,7 +388,8 @@ inline bool RowAggregation::isNull(const RowGroup* pRowGroup, const Row& row, in
else
{
//@bug 1821
ret = (row.equals(string(""), col) || row.equals(joblist::CPNULLSTRMARK, col));
auto const str = row.getConstString(col);
ret = str.length() == 0 || str.eq(utils::ConstString(joblist::CPNULLSTRMARK));
}
break;
@ -486,7 +487,8 @@ inline bool RowAggregation::isNull(const RowGroup* pRowGroup, const Row& row, in
case execplan::CalpontSystemCatalog::VARBINARY:
case execplan::CalpontSystemCatalog::BLOB:
{
ret = (row.equals(string(""), col) || row.equals(joblist::CPNULLSTRMARK, col));
auto const str = row.getConstString(col);
ret = str.length() == 0 || str.eq(utils::ConstString(joblist::CPNULLSTRMARK));
break;
}
@ -949,8 +951,7 @@ void RowAggregation::initMapData(const Row& rowIn)
}
else
{
fRow.setStringField(rowIn.getStringPointer(colIn),
rowIn.getStringLength(colIn), colOut);
fRow.setStringField(rowIn.getConstString(colIn), colOut);
}
break;