database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-01 06:46:55 +03:00
Code Activity

MCOL-4043 Fix memory leaks - 1

Browse Source 
simpleScalarFilterToParseTree() performs a dynamic allocation
of a ParseTree object, but this memory is never freed later.
We now keep track of this allocation and perform the delete
in the JobList dtor after the query finishes.
This commit is contained in:
Gagan Goel
2020-06-11 19:01:40 -04:00
parent feee26f1ab
commit 881091c535
7 changed files with 54 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dbcon/joblist/jlf_subquery.cpp
View File

@ -192,7 +192,10 @@ void ssfInHaving(ParseTree* pt, void* obj)
pt->right(parseTree->right());
pt->data(parseTree->data());
jobInfo->dynamicParseTreeVec.push_back(make_pair(parseTree, pt));
// don't delete the parseTree, it has been placed in the plan.
// Instead, we use the dynamicParseTreeVec above for deletion
// in the JobList dtor after the query executes.
// delete parseTree;
}
else
@ -627,7 +630,10 @@ void doSimpleScalarFilter(ParseTree* p, JobInfo& jobInfo)
// create job steps for each simple filter
JLF_ExecPlanToJobList::walkTree(parseTree, jobInfo);
jobInfo.dynamicParseTreeVec.push_back(make_pair(parseTree, ccp));
// don't delete the parseTree, it has been placed in the plan.
// Instead, we use the dynamicParseTreeVec above for deletion
// in the JobList dtor after the query executes.
// delete parseTree;
}
else