database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4126 Don't reset ci->tableOid if not autocommit.

Browse Source
This commit is contained in:
David Hall
2020-06-30 11:21:30 -05:00
parent 0a2fe7d2fb
commit 8179ffffdf
1 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
dbcon/mysql/ha_mcs_impl.cpp
View File

@ -1604,7 +1604,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
aTableName.schema = first_table->table->s->db.str; aTableName.schema = first_table->table->s->db.str;
aTableName.table = first_table->table->s->table_name.str; aTableName.table = first_table->table->s->table_name.str;
} }
#if 0
CalpontSystemCatalog::ROPair roPair; CalpontSystemCatalog::ROPair roPair;
try try
@ -1624,6 +1624,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
} }
ci->tableOid = roPair.objnum; ci->tableOid = roPair.objnum;
#endif
CalpontDMLPackage* pDMLPackage = 0; CalpontDMLPackage* pDMLPackage = 0;
// dmlStmt += ";"; // dmlStmt += ";";
IDEBUG( cout << "STMT: " << dmlStmt << " and sessionID " << thd->thread_id << endl ); IDEBUG( cout << "STMT: " << dmlStmt << " and sessionID " << thd->thread_id << endl );
@ -1670,7 +1671,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
thd->raise_error_printf(ER_INTERNAL_ERROR, emsg.c_str()); thd->raise_error_printf(ER_INTERNAL_ERROR, emsg.c_str());
ci->rc = 1; ci->rc = 1;
thd->set_row_count_func(0); thd->set_row_count_func(0);
return 0; return 1;
} }
} }
else else
@ -1734,7 +1735,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
thd->raise_error_printf(ER_INTERNAL_ERROR, emsg.c_str()); thd->raise_error_printf(ER_INTERNAL_ERROR, emsg.c_str());
ci->rc = 1; ci->rc = 1;
thd->set_row_count_func(0); thd->set_row_count_func(0);
return 0; return 1;
} }
{ {
@ -1884,7 +1885,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
thd->raise_error_printf(ER_INTERNAL_ERROR, ie.what()); thd->raise_error_printf(ER_INTERNAL_ERROR, ie.what());
ci->rc = -1; ci->rc = -1;
thd->set_row_count_func(0); thd->set_row_count_func(0);
return 0; return -1;
} }
int minColWidth = -1; int minColWidth = -1;
@ -1968,6 +1969,25 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
//querystats::QueryStats stats; //querystats::QueryStats stats;
string tableLockInfo; string tableLockInfo;
// Save the tableOid for the COMMIT | ROLLBACK
CalpontSystemCatalog::ROPair roPair;
try
{
roPair = csc->tableRID( aTableName );
}
catch (IDBExcept& ie)
{
setError(thd, ER_INTERNAL_ERROR, ie.what());
return ER_INTERNAL_ERROR;
}
catch (std::exception& ex)
{
setError(thd, ER_INTERNAL_ERROR,
logging::IDBErrorInfo::instance()->errorMsg(ERR_SYSTEM_CATALOG) + ex.what());
return ER_INTERNAL_ERROR;
}
ci->tableOid = roPair.objnum;
// Send the request to DMLProc and wait for a response. // Send the request to DMLProc and wait for a response.
try try
{ {
@ -2196,6 +2216,9 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
errorMsg = "Unknown error caught"; errorMsg = "Unknown error caught";
b = 1; b = 1;
} }
// Clear tableOid for the next SQL statement
ci->tableOid = 0;
} }
} }
@ -2249,8 +2272,6 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
delete ci->dmlProc; delete ci->dmlProc;
ci->dmlProc = nullptr; ci->dmlProc = nullptr;
ci->tableOid = 0;
return rc; return rc;
} }