1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00

MCOL-5618: Fix after testing

[add] -P to restore help in mcs_backup_restore.sh
[fix] -f argument default value in both backup and restore wrapper commands
[fix] -i argument behaviour and type + default value
[fix] -P argument position and help for both backup and restore wrapper commands
[fix] disable some pylint warning for both backup and restore wrapper files
This commit is contained in:
mariadb-AlanMologorsky
2024-06-25 05:39:26 +03:00
committed by Alan Mologorsky
parent 7ec8f3df9a
commit 7b0a04270f
3 changed files with 47 additions and 33 deletions

View File

@ -13,7 +13,8 @@ from mcs_cluster_tool.helpers import cook_sh_arg
logger = logging.getLogger('mcs_cli')
# pylint: disable=unused-argument
# pylint: disable=unused-argument, too-many-arguments, too-many-locals
# pylint: disable=invalid-name, line-too-long
@handle_output
@ -94,23 +95,18 @@ def backup(
)
] = 'LocalStorage',
i: Annotated[
bool,
str,
typer.Option(
'-i/-no-i', '--incremental/--no--incremental',
help='Adds columnstore deltas to an existing full backup.'
)
] = False,
P: Annotated[
int,
typer.Option(
'-P', '--parallel',
'-i', '--incremental',
help=(
'Determines if columnstore data directories will have '
'multiple rsync running at the same time for different '
'subfolders to parallelize writes.'
)
'Adds columnstore deltas to an existing full backup. '
'Backup folder to apply increment could be a value or '
'"auto_most_recent" - the incremental backup applies to '
'last full backup.'
),
show_default=False
)
] = 4,
] = '',
ha: Annotated[
bool,
typer.Option(
@ -127,9 +123,10 @@ def backup(
str,
typer.Option(
'-f', '--config-file',
help='Path to backup configuration file to load variables from.'
help='Path to backup configuration file to load variables from.',
show_default=False
)
] = '.cs-backup-config',
] = '',
sbrm: Annotated[
bool,
typer.Option(
@ -202,9 +199,22 @@ def backup(
str,
typer.Option(
'-c', '--compress',
help='Compress backup in X format - Options: [ pigz ].'
help='Compress backup in X format - Options: [ pigz ].',
show_default=False
)
] = '',
P: Annotated[
int,
typer.Option(
'-P', '--parallel',
help=(
'Determines if columnstore data directories will have '
'multiple rsync running at the same time for different '
'subfolders to parallelize writes. '
'Ignored if "-c/--compress" argument not set.'
)
)
] = 4,
nb: Annotated[
str,
typer.Option(