database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4988 Table lock remained after DML failure due to DBRM in read-only mode.

Browse Source 
DMLProcessor functor earlier did not check if the DBRM was in read-only mode.
This allowed DML statements to continue execution to the point where it locks
the table and then sends the statement down to the WriteEngineServer, which
ultimately returns back in an error state to DMLProc when it fails to perform
BRM updates due to DBRM in read-only mode. This caused a lingering table lock
in the system which could only be cleared on a system restart.

As a fix, we add a check in the DMLProcessor functor to detect if DBRM is in
read only mode, and if so, return back early in the execution of the DML
statement.
This commit is contained in:
Gagan Goel
2023-08-11 12:49:31 -04:00
parent c97c8b672e
commit 712d34a407
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
dmlproc/dmlprocessor.cpp
View File

@ -1387,7 +1387,7 @@ void DMLProcessor::operator()()
0) // > 0 implies succesful retrieval. It doesn't imply anything about the contents
{
messageqcpp::ByteStream results;
const char* responseMsg = 0;
std::string responseMsg;
bool bReject = false;
// Check to see if we're in write suspended mode
@ -1433,6 +1433,14 @@ void DMLProcessor::operator()()
}
}
// MCOL-4988 Check if DBRM is in READ ONLY mode
if (fDbrm->isReadWrite() == BRM::ERR_READONLY)
{
BRM::errString(BRM::ERR_READONLY, responseMsg);
status = DMLPackageProcessor::DBRM_READ_ONLY;
bReject = true;
}
if (bReject)
{
// For batch insert, we need to send a lastpkg message