database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-08 14:22:09 +03:00
Code Activity

fix(funcexp): MCOL-4671 Fix behaviour of LEFT/RIGHT functions when negative trim length value is passedB

Browse Source
This commit is contained in:
Alexander Presnyakov
2024-07-03 19:11:19 +04:00
committed by Leonid Fedorov
parent bfe49a8345
commit 6d1c6d8242
4 changed files with 97 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
utils/funcexp/func_right.cpp
View File

@@ -56,15 +56,17 @@ std::string Func_right::getStrVal(rowgroup::Row& row, FunctionParm& fp, bool& is
const char* pos = src.str();
const char* end = pos + binLen;
size_t trimLength = fp[1]->data()->getUintVal(row, isNull);
// Negative trim length values are legal, but they don't make any real sense
int64_t trimLength = fp[1]->data()->getUintVal(row, isNull);
if (isNull || trimLength <= 0)
return "";
size_t trimLengthPositive = static_cast<size_t>(trimLength); // now we are sure it is positive
size_t start = cs->numchars(pos, end); // Here, start is number of characters in src
if (start <= trimLength)
if (start <= trimLengthPositive)
return src.safeString("");
start = cs->charpos(pos, end,
start - trimLength); // Here, start becomes number of bytes into src to start copying
start - trimLengthPositive); // Here, start becomes number of bytes into src to start copying
std::string ret(pos + start, binLen - start);
return ret;