database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-5385: Delete RowGroup::setData and make Pointer ctor explicit (#2808)

Browse Source 
* Delete RowGroup::setData and make Pointer ctor explicit

* some push_backs replaced with emplace_backs

* Fixes of review notes
This commit is contained in:
Leonid Fedorov
2023-04-13 03:55:30 +03:00
committed by GitHub
parent 5675a418b7
commit 6c32c658d5
13 changed files with 37 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
utils/rowgroup/rowaggregation.cpp
View File

@ -696,7 +696,7 @@ void RowAggregation::initialize()
// Keep a copy of the null row to initialize new map entries.
fRowGroupOut->initRow(&fNullRow, true);
fNullRowData.reset(new uint8_t[fNullRow.getSize()]);
fNullRow.setData(fNullRowData.get());
fNullRow.setData(rowgroup::Row::Pointer(fNullRowData.get()));
copyRow(fRow, &fNullRow);
// Lazy approach w/o a mapping b/w fFunctionCols idx and fRGContextColl idx
@ -4685,7 +4685,7 @@ void RowAggregationSubDistinct::setInputOutput(const RowGroup& pRowGroupIn, RowG
// initialize the aggregate row
fRowGroupOut->initRow(&fDistRow, true);
fDistRowData.reset(new uint8_t[fDistRow.getSize()]);
fDistRow.setData(fDistRowData.get());
fDistRow.setData(rowgroup::Row::Pointer(fDistRowData.get()));
}
//------------------------------------------------------------------------------