1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00

MCOL-5932: fix heap buffer overflow with minimal revert of MCOL-5776 breaking change (#3445)

This commit is contained in:
Leonid Fedorov
2025-04-15 17:46:25 +04:00
committed by GitHub
parent 16d9b56608
commit 6a712dc0ad
6 changed files with 272 additions and 15 deletions

View File

@ -169,7 +169,10 @@ void pushReturnedCol(gp_walk_info& gwi, Item* from, SRCP rc)
{
Item* ith = gwi.processed[i].first;
bool same = ith->eq(from, false);
// made within MCOL-5776 produced bug MCOL-5932 so, the check of equal columns is disabled
// FIXME: enable the check of equal columns
//bool same = ith->eq(from, false);
bool same = false;
if (same && ith->type() == Item::FUNC_ITEM)
{
@ -8036,7 +8039,8 @@ int getSelectPlan(gp_walk_info& gwi, SELECT_LEX& select_lex, SCSEP& csep, bool i
continue;
}
// FIXME: usage of pushReturnedCol instead of gwi.returnedCols.push_back(srcp) here
// made within MCOL-5776 produced bug MCOL-5932 so, the check of equal columns is disabled
pushReturnedCol(gwi, item, srcp);
}
else // This was a vtable post-process block