database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4531 New string-to-decimal conversion implementation

Browse Source 
This change fixes:

MCOL-4462 CAST(varchar_expr AS DECIMAL(M,N)) returns a wrong result
MCOL-4500 Bit functions processing throws internally trying to cast char into decimal representation
MCOL-4532 CAST(AS DECIMAL) returns a garbage for large values

Also, this change makes string-to-decimal conversion 5-10 times faster,
depending on exact data.
Performance implemenent is achieved by the fact that (unlike in the old
implementation), the new version does not do any "string" object copying.
This commit is contained in:
Alexander Barkov
2021-01-28 21:44:41 +04:00
parent de581897c9
commit 69da915160
11 changed files with 1150 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
utils/funcexp/func_bitwise.cpp
View File

@ -41,6 +41,8 @@ using namespace logging;
#include "mcs_int64.h"
#include "mcs_decimal.h"
#include "dataconvert.h"
#include "numericliteral.h"
using namespace dataconvert;
namespace
@ -163,14 +165,14 @@ datatypes::TUInt64Null GenericToBitOperand(
const string& str = parm->data()->getStrVal(row, tmpIsNull);
if (tmpIsNull)
return datatypes::TUInt64Null();
static const datatypes::SystemCatalog::TypeAttributesStd
attr(datatypes::MAXDECIMALWIDTH, 6, datatypes::INT128MAXPRECISION);
int128_t val = attr.decimal128FromString(str);
datatypes::Decimal d(0, attr.scale, attr.precision, &val);
val = d.getPosNegRoundedIntegralPart(0).getValue();
return ConvertToBitOperand<int128_t>(val);
}
datatypes::DataCondition cnverr;
literal::Converter<literal::SignedNumericLiteral> cnv(str, cnverr);
cnv.normalize();
return cnv.negative() ?
datatypes::TUInt64Null((uint64_t)cnv.toPackedSDecimal<int64_t>(0, cnverr)) :
datatypes::TUInt64Null(cnv.toPackedUDecimal<uint64_t>(0, cnverr));
}
case execplan::CalpontSystemCatalog::DECIMAL:
case execplan::CalpontSystemCatalog::UDECIMAL:
return DecimalToBitOperand(row, parm, thisFunc);