database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4810 Add support for missed operation for longStrings.

Browse Source
This commit is contained in:
Denis Khalikov
2021-10-14 10:50:37 +03:00
parent 07f2e59d65
commit 6393c6d019
3 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
utils/messageqcpp/bytestream.cpp
View File

@ -545,6 +545,7 @@ void ByteStream::swap(ByteStream& rhs)
std::swap(fCurInPtr, rhs.fCurInPtr);
std::swap(fCurOutPtr, rhs.fCurOutPtr);
std::swap(fMaxLen, rhs.fMaxLen);
std::swap(longStrings, rhs.longStrings);
}
ifstream& operator>>(ifstream& ifs, ByteStream& bs)
@ -564,7 +565,31 @@ bool ByteStream::operator==(const ByteStream& b) const
if (b.length() != length())
return false;
return (memcmp(fCurOutPtr, b.fCurOutPtr, length()) == 0);
if (memcmp(fCurOutPtr, b.fCurOutPtr, length()) != 0)
return false;
// Check the `longString` sizes.
if (longStrings.size() != b.longStrings.size())
return false;
// For each `longString`.
for (uint32_t i = 0, e = b.longStrings.size(); i < e; ++i)
{
const auto* leftMemChunk = reinterpret_cast<MemChunk*>(longStrings[i].get());
const auto* rightMemChunk = reinterpret_cast<MemChunk*>(b.longStrings[i].get());
if (leftMemChunk == nullptr || rightMemChunk == nullptr)
return false;
const uint32_t leftSize = leftMemChunk->currentSize;
const uint32_t rightSize = rightMemChunk->currentSize;
if (leftSize != rightSize)
return false;
if (memcmp(leftMemChunk->data, rightMemChunk->data, leftSize) != 0)
return false;
}
return true;
}
bool ByteStream::operator!=(const ByteStream& b) const