database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

Fixes for Decimal multiplication overflow check and RowGroup UTs

Browse Source
This commit is contained in:
Roman Nozdrin
2020-11-22 17:55:22 +00:00
parent 23af547fb8
commit 5ba6737965
4 changed files with 50 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/mcs_decimal-tests.cpp
View File

@ -508,7 +508,6 @@ TEST(Decimal, additionWithOverflowCheck)
result.scale = 1;
result.precision = 38;
result.s128Value = 0;
EXPECT_THROW(doAdd(l, r, result), logging::OperationOverflowExcept);
// Normal execution w/o overflow
@ -880,6 +879,26 @@ TEST(Decimal, multiplicationWithOverflowCheck)
EXPECT_NO_THROW(doMultiply(l, r, result));
EXPECT_EQ("21267647932558653966460912964485513216", result.toString());
l.setTSInt128Value((int128_t)1 << 122);
l.setScale(0);
r.setTSInt128Value(100);
r.setScale(0);
EXPECT_THROW(doMultiply(l, r, result), logging::OperationOverflowExcept);
l.setTSInt128Value((int128_t)1 << 65);
l.setScale(0);
r.setTSInt128Value((int128_t)1 << 64);
r.setScale(0);
EXPECT_THROW(doMultiply(l, r, result), logging::OperationOverflowExcept);
l.setTSInt128Value((int128_t)1 << 122);
l.setScale(0);
r.setTSInt128Value(2);
r.setScale(0);
EXPECT_NO_THROW(doMultiply(l, r, result));
EXPECT_EQ("10633823966279326983230456482242756608", result.toString());
}
TEST(Decimal, DecimalToStringCheckScale0)