database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-01 06:46:55 +03:00
Code Activity

MCOL-4671: MCOL-4622: fix the behavior of both PRs

Browse Source 
first was playing different with RIGHT and LEFT functions(using the getUintVal and getIntVal accordingly)
https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/3234
second introduced round for ints from double, but added it to uint but not to int missing long doubles as well
https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/3480
This commit is contained in:
Leonid Fedorov
2025-05-22 19:07:45 +00:00
committed by Leonid Fedorov
parent 842ec9dbff
commit 5814a80b50
5 changed files with 68 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
utils/funcexp/func_left.cpp
View File

@ -60,7 +60,7 @@ std::string Func_left::getStrVal(rowgroup::Row& row, FunctionParm& fp, bool& isN
if (isNull || trimLength <= 0)
return "";
size_t trimLengthPositive = static_cast<size_t>(trimLength); // now we are sure it is positive
size_t trimLengthPositive = trimLength; // now we are sure it is positive
size_t charPos;
if ((binLen <= trimLengthPositive) || (binLen <= (charPos = cs->charpos(pos, end, trimLengthPositive))))