database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4285 For Insert...Select, pass the is_cache_insert=true

Browse Source 
flag to ha_mcs_impl_start_bulk_insert.

An earlier commit to fix LDI under replication changed the call in
ha_mcs_cache::start_bulk_insert for a non-insert command from
parent::start_bulk_insert_from_cache to parent::start_bulk_insert.
This commit reverts that change for INSERT...SELECT operation.
This commit is contained in:
Gagan Goel
2020-10-15 13:30:36 -04:00
parent 92d861d980
commit 50a4fd9f39
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
dbcon/mysql/ha_mcs.cpp
View File

@ -1219,6 +1219,8 @@ my_bool get_status_and_flush_cache(void *param,
int error;
enum_sql_command sql_command= cache->table->in_use->lex->sql_command;
cache->sql_command= sql_command;
cache->insert_command= (sql_command == SQLCOM_INSERT ||
sql_command == SQLCOM_LOAD);
/*
@ -1781,7 +1783,16 @@ void ha_mcs_cache::start_bulk_insert(ha_rows rows, uint flags)
bzero(&cache_handler->copy_info, sizeof(cache_handler->copy_info));
return cache_handler->start_bulk_insert(rows, flags);
}
return parent::start_bulk_insert(rows, flags);
else if (sql_command == SQLCOM_INSERT_SELECT)
{
return parent::start_bulk_insert_from_cache(rows, flags);
}
// sql_command == SQLCOM_END:
// See the comment in get_status_and_flush_cache
else
{
return parent::start_bulk_insert(rows, flags);
}
}
else
{