database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-4031 More accurate memory usage counting while sorting

Browse Source
This commit is contained in:
Alexey Antipovsky
2020-12-16 18:21:35 +03:00
parent 86a32c2bc3
commit 5080e1ae53
4 changed files with 46 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
dbcon/joblist/limitedorderby.cpp
View File

@ -42,9 +42,10 @@ using namespace ordering;
namespace joblist
{
const uint64_t LimitedOrderBy::fMaxUncommited = 102400; // 100KiB - make it configurable?
// LimitedOrderBy class implementation
LimitedOrderBy::LimitedOrderBy() : fStart(0), fCount(-1)
LimitedOrderBy::LimitedOrderBy() : fStart(0), fCount(-1), fUncommitedMemory(0)
{
fRule.fIdbCompare = this;
}
@ -122,6 +123,20 @@ void LimitedOrderBy::processRow(const rowgroup::Row& row)
OrderByRow newRow(fRow0, fRule);
fOrderByQueue.push(newRow);
uint64_t memSizeInc = sizeof(newRow);
fUncommitedMemory += memSizeInc;
if (fUncommitedMemory >= fMaxUncommited)
{
fMemSize += fUncommitedMemory;
if (!fRm->getMemory(fUncommitedMemory, fSessionMemLimit))
{
cerr << IDBErrorInfo::instance()->errorMsg(fErrorCode) << " @"
<< __FILE__ << ":" << __LINE__;
throw IDBExcept(fErrorCode);
}
fUncommitedMemory = 0;
}
// add to the distinct map
if (fDistinct)
fDistinctMap->insert(fRow0.getPointer());
@ -132,7 +147,7 @@ void LimitedOrderBy::processRow(const rowgroup::Row& row)
if (fRowGroup.getRowCount() >= fRowsPerRG)
{
fDataQueue.push(fData);
uint64_t newSize = fRowsPerRG * fRowGroup.getRowSize();
uint64_t newSize = fRowGroup.getSizeWithStrings() - fRowGroup.getHeaderSize();
fMemSize += newSize;
if (!fRm->getMemory(newSize, fSessionMemLimit))
@ -173,6 +188,18 @@ void LimitedOrderBy::processRow(const rowgroup::Row& row)
*/
void LimitedOrderBy::finalize()
{
if (fUncommitedMemory > 0)
{
fMemSize += fUncommitedMemory;
if (!fRm->getMemory(fUncommitedMemory, fSessionMemLimit))
{
cerr << IDBErrorInfo::instance()->errorMsg(fErrorCode) << " @"
<< __FILE__ << ":" << __LINE__;
throw IDBExcept(fErrorCode);
}
fUncommitedMemory = 0;
}
queue<RGData> tempQueue;
if (fRowGroup.getRowCount() > 0)
fDataQueue.push(fData);
@ -181,7 +208,7 @@ void LimitedOrderBy::finalize()
{
// *DRRTUY Very memory intensive. CS needs to account active
// memory only and release memory if needed.
uint64_t memSizeInc = fRowsPerRG * fRowGroup.getRowSize();
uint64_t memSizeInc = fRowGroup.getSizeWithStrings() - fRowGroup.getHeaderSize();
fMemSize += memSizeInc;
if (!fRm->getMemory(memSizeInc, fSessionMemLimit))

2
dbcon/joblist/limitedorderby.h
View File

@ -63,6 +63,8 @@ public:
protected:
uint64_t fStart;
uint64_t fCount;
uint64_t fUncommitedMemory;
static const uint64_t fMaxUncommited;
};

12
utils/rowgroup/rowgroup.h
View File

@ -1435,6 +1435,7 @@ public:
// this returns the size of the row data with the string table
inline uint64_t getSizeWithStrings() const;
inline uint64_t getSizeWithStrings(uint64_t n) const;
// sets the row count to 0 and the baseRid to something
// effectively initializing whatever chunk of memory
@ -1708,12 +1709,17 @@ inline uint32_t RowGroup::getRowSizeWithStrings() const
return oldOffsets[columnCount];
}
inline uint64_t RowGroup::getSizeWithStrings() const
inline uint64_t RowGroup::getSizeWithStrings(uint64_t n) const
{
if (strings == NULL)
return getDataSize();
return getDataSize(n);
else
return getDataSize() + strings->getSize();
return getDataSize(n) + strings->getSize();
}
inline uint64_t RowGroup::getSizeWithStrings() const
{
return getSizeWithStrings(getRowCount());
}
inline bool RowGroup::isCharType(uint32_t colIndex) const

2
utils/windowfunction/idborderby.cpp
View File

@ -772,7 +772,7 @@ void IdbOrderBy::initialize(const RowGroup& rg)
// initialize rows
IdbCompare::initialize(rg);
uint64_t newSize = fRowsPerRG * rg.getRowSize();
uint64_t newSize = rg.getSizeWithStrings(fRowsPerRG);
fMemSize += newSize;
if (!fRm->getMemory(newSize, fSessionMemLimit))