You've already forked mariadb-columnstore-engine
mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-07-30 19:23:07 +03:00
Fix a compiler error related to signed v/s unsigned integer comparison. (#2915)
This commit is contained in:
@ -5324,7 +5324,7 @@ ReturnedColumn* buildAggregateColumn(Item* item, gp_walk_info& gwi)
|
|||||||
// in groupconcat.cpp when ExeMgr processes groupconcat. As a temporary
|
// in groupconcat.cpp when ExeMgr processes groupconcat. As a temporary
|
||||||
// fix, we cap off the max groupconcat length to std::numeric_limits<int32_t>::max().
|
// fix, we cap off the max groupconcat length to std::numeric_limits<int32_t>::max().
|
||||||
// The proper fix would be to change colWidth type to uint32_t.
|
// The proper fix would be to change colWidth type to uint32_t.
|
||||||
if (isp->max_length <= std::numeric_limits<int32_t>::max())
|
if (isp->max_length <= static_cast<uint32_t>(std::numeric_limits<int32_t>::max()))
|
||||||
{
|
{
|
||||||
ct.colWidth = isp->max_length;
|
ct.colWidth = isp->max_length;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user