database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4612 A subquery with a union for DECIMAL and BIGINT returns zeros.

Browse Source 
In this patch, we set the unioned type to a wide decimal, if any of the
numeric columns involved in the union operation have a precision > 18
(which is also possible for BIGINT/UBIGINT types) and <= 38.
This commit is contained in:
Gagan Goel
2021-04-29 10:36:36 +00:00
parent 42d203ac3c
commit 4e9307fa6d
4 changed files with 187 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
mysql-test/columnstore/csinternal/devregression/r/mcs7147_regression_bug4388.result
View File

@ -1,9 +1,11 @@
USE tpch1;
create table if not exists bug4388(
set default_storage_engine=columnstore;
drop table if exists bug4388;
create table bug4388(
`venta_clave` int(10) DEFAULT NULL,
`cantidad` decimal(10,3) DEFAULT NULL,
`changev` decimal(18,4) DEFAULT NULL
) engine=columnstore;
);
insert into bug4388 values (null,null,6.8000);
select coalesce(sum(changev),0) as col1 from bug4388;
col1
@ -38,4 +40,76 @@ select sum(co) from ( select sum(col1) as co from (select sum(changev)
as col1 from bug4388 ) t ) res;
sum(co)
6.8000
select sum(col1) as co from ( select 984467440737095516
as col1 union all select coalesce(sum(changev),0) as col1 from
bug4388 ) t;
co
984467440737095522.8000
select sum(col1) as co from ( select 18446744073709551612
as col1 union all select coalesce(sum(changev),0) as col1 from
bug4388 ) t;
co
18446744073709551618.8000
drop table bug4388;
#
# MCOL-4613 Garbage result of a union between huge narrow DECIMAL and BIGINT
#
drop table if exists t1;
drop table if exists t2;
drop table if exists t3;
create table t1 (a decimal(17,1), b bigint);
insert into t1 values (9999999999999999.9, 999999999999999999);
select * from (select a from t1 union select b from t1) tu order by a;
a
9999999999999999.9
999999999999999999.0
drop table t1;
#
# MCOL-4612 A subquery with a union for DECIMAL and BIGINT returns zeros
#
create table t1 (a decimal(17,1), b bigint);
insert into t1 values (1, 1);
insert into t1 values (9999999999999999, 99999999999999999);
select * from (select a from t1 union select b from t1) tu order by a;
a
1.0
9999999999999999.0
99999999999999999.0
select * from (select a from t1 union all select b from t1) tu order by a;
a
1.0
1.0
9999999999999999.0
99999999999999999.0
drop table t1;
create table t1 (a decimal(18,5), b decimal(18,5) unsigned);
create table t2 (a bigint, b bigint unsigned);
create table t3 (a decimal(38,10), b decimal(38,10) unsigned);
insert into t1 values
(-1234567890123.12345, 1234567890123.12345),
(-1234567890123.1234, 1234567890123.1234),
(-9999999999999.99999, 9999999999999.99999),
(-999999999999.99999, 999999999999.99999),
(-99999999999.99999, 99999999999.99999);
insert into t2 values
(-123456789012345, 123456789012345),
(9223372036854775807, 18446744073709551613),
(-9223372036854775806, 0);
insert into t3 values
(-9999999999999999999999999999.9999999999, 9999999999999999999999999999.9999999999),
(-1234567890123456789012345678.9012345678, 1234567890123456789012345678.9012345678);
select * from (select a,b from t1 union select a,b from t2 union select a,b from t3) tu order by a,b;
a b
-9999999999999999999999999999.9999999999 9999999999999999999999999999.9999999999
-1234567890123456789012345678.9012345678 1234567890123456789012345678.9012345678
-9223372036854775806.0000000000 0.0000000000
-123456789012345.0000000000 123456789012345.0000000000
-9999999999999.9999900000 9999999999999.9999900000
-1234567890123.1234500000 1234567890123.1234500000
-1234567890123.1234000000 1234567890123.1234000000
-999999999999.9999900000 999999999999.9999900000
-99999999999.9999900000 99999999999.9999900000
9223372036854775807.0000000000 18446744073709551613.0000000000
drop table t1;
drop table t2;
drop table t3;

76
mysql-test/columnstore/csinternal/devregression/t/mcs7147_regression_bug4388.test
View File

@ -8,11 +8,17 @@
#
USE tpch1;
#
create table if not exists bug4388(
set default_storage_engine=columnstore;
--disable_warnings
drop table if exists bug4388;
--enable_warnings
create table bug4388(
`venta_clave` int(10) DEFAULT NULL,
`cantidad` decimal(10,3) DEFAULT NULL,
`changev` decimal(18,4) DEFAULT NULL
) engine=columnstore;
);
insert into bug4388 values (null,null,6.8000);
select coalesce(sum(changev),0) as col1 from bug4388;
select sum(co) + 0 from ( select sum(col1) as co from ( select 0
@ -31,6 +37,68 @@ select sum(col1) from
select sum(co) from (select sum(changev) as co from bug4388 ) t;
select sum(co) from ( select sum(col1) as co from (select sum(changev)
as col1 from bug4388 ) t ) res;
drop table bug4388;
#
select sum(col1) as co from ( select 984467440737095516
as col1 union all select coalesce(sum(changev),0) as col1 from
bug4388 ) t;
select sum(col1) as co from ( select 18446744073709551612
as col1 union all select coalesce(sum(changev),0) as col1 from
bug4388 ) t;
drop table bug4388;
--echo #
--echo # MCOL-4613 Garbage result of a union between huge narrow DECIMAL and BIGINT
--echo #
--disable_warnings
drop table if exists t1;
drop table if exists t2;
drop table if exists t3;
--enable_warnings
# Original test case from the MCOL-4613 issue description
create table t1 (a decimal(17,1), b bigint);
insert into t1 values (9999999999999999.9, 999999999999999999);
select * from (select a from t1 union select b from t1) tu order by a;
drop table t1;
--echo #
--echo # MCOL-4612 A subquery with a union for DECIMAL and BIGINT returns zeros
--echo #
# Original test case from the MCOL-4612 issue description
create table t1 (a decimal(17,1), b bigint);
insert into t1 values (1, 1);
insert into t1 values (9999999999999999, 99999999999999999);
select * from (select a from t1 union select b from t1) tu order by a;
select * from (select a from t1 union all select b from t1) tu order by a;
drop table t1;
# Additional test cases for MCOL-4613 and MCOL-4612
create table t1 (a decimal(18,5), b decimal(18,5) unsigned);
create table t2 (a bigint, b bigint unsigned);
create table t3 (a decimal(38,10), b decimal(38,10) unsigned);
insert into t1 values
(-1234567890123.12345, 1234567890123.12345),
(-1234567890123.1234, 1234567890123.1234),
(-9999999999999.99999, 9999999999999.99999),
(-999999999999.99999, 999999999999.99999),
(-99999999999.99999, 99999999999.99999);
insert into t2 values
(-123456789012345, 123456789012345),
(9223372036854775807, 18446744073709551613),
(-9223372036854775806, 0);
insert into t3 values
(-9999999999999999999999999999.9999999999, 9999999999999999999999999999.9999999999),
(-1234567890123456789012345678.9012345678, 1234567890123456789012345678.9012345678);
select * from (select a,b from t1 union select a,b from t2 union select a,b from t3) tu order by a,b;
drop table t1;
drop table t2;
drop table t3;