database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

Fix warnings found in DEBUG combined build

Browse Source 
Fixes:
* Irrelevant where conditions
* Irrelevant const
* A potential infinite loop in treenode
* Bad implicit case fallthroughs
* Explicit markings for required case fallthroughs
* Unused variables
* Unused function

Also disabled some warnings for now which we should fix later.
This commit is contained in:
Andrew Hutchings
2019-12-06 14:59:17 +00:00
parent 118efd473b
commit 49994f7bc3
20 changed files with 62 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
versioning/BRM/extentmap.cpp
View File

@ -1839,7 +1839,7 @@ int ExtentMap::lookupLocal(int OID, uint32_t partitionNum, uint16_t segmentNum,
#endif
int entries, i, offset;
if (OID < 0 || fileBlockOffset < 0)
if (OID < 0)
{
log("ExtentMap::lookup(): OID and FBO must be >= 0", logging::LOG_TYPE_DEBUG);
throw invalid_argument("ExtentMap::lookup(): OID and FBO must be >= 0");
@ -1892,7 +1892,7 @@ int ExtentMap::lookupLocal_DBroot(int OID, uint16_t dbroot, uint32_t partitionNu
#endif
int entries, i, offset;
if (OID < 0 || fileBlockOffset < 0)
if (OID < 0)
{
log("ExtentMap::lookup(): OID and FBO must be >= 0", logging::LOG_TYPE_DEBUG);
throw invalid_argument("ExtentMap::lookup(): OID and FBO must be >= 0");
@ -1955,7 +1955,7 @@ int ExtentMap::lookupLocalStartLbid(int OID,
#endif
int entries, i;
if (OID < 0 || fileBlockOffset < 0)
if (OID < 0)
{
log("ExtentMap::lookupLocalStartLbid(): OID and FBO must be >= 0",
logging::LOG_TYPE_DEBUG);