database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-08 14:22:09 +03:00
Code Activity

MCOL-1559 trim strings before compare on equal operator

Browse Source
This commit is contained in:
David Hall
2019-06-27 10:18:10 -05:00
parent 567de10204
commit 474039b6cf
4 changed files with 38 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
dbcon/execplan/predicateoperator.h
View File

@@ -466,6 +466,7 @@ inline bool PredicateOperator::getBoolVal(rowgroup::Row& row, bool& isNull, Retu
return false;
return strTrimCompare(val1, rop->getStrVal(row, isNull)) && !isNull;
// return strCompare(val1, rop->getStrVal(row, isNull)) && !isNull;
}

9
dbcon/joblist/jlf_execplantojoblist.cpp
View File

@@ -1635,6 +1635,8 @@ const JobStepVector doSimpleFilter(SimpleFilter* sf, JobInfo& jobInfo)
}
string constval(cc->constval());
// Because, on a filter, we want to compare ignoring trailing spaces
// boost::algorithm::trim_right(constval);
CalpontSystemCatalog::OID dictOid = 0;
@@ -2770,7 +2772,8 @@ const JobStepVector doConstantFilter(const ConstantFilter* cf, JobInfo& jobInfo)
cop = COMPARE_NIL;
string value = cc->constval();
// Because, on a filter, we want to compare ignoring trailing spaces
// boost::algorithm::trim_right(value);
pds->addFilter(cop, value);
}
@@ -2853,7 +2856,8 @@ const JobStepVector doConstantFilter(const ConstantFilter* cf, JobInfo& jobInfo)
cop = COMPARE_NIL;
string value = cc->constval();
// Because, on a filter, we want to compare ignoring trailing spaces
// boost::algorithm::trim_right(value);
pds->addFilter(cop, value);
}
@@ -2960,7 +2964,6 @@ const JobStepVector doConstantFilter(const ConstantFilter* cf, JobInfo& jobInfo)
int64_t value = 0;
string constval = cc->constval();
// @bug 1151 string longer than colwidth of char/varchar.
uint8_t rf = 0;
bool isNull = ConstantColumn::NULLDATA == cc->type();