database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

Merge pull request #1613 from tntnatbry/MCOL-641-alter-table-fix

Browse Source 
MCOL-641 Fix alter table add wide decimal column.
This commit is contained in:
Roman Nozdrin
2020-11-26 18:17:01 +03:00
committed by GitHub
parent b106daacb7 995cadef2d
commit 454ec4be99
32 changed files with 62 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
datatypes/mcs_datatype.cpp
View File

@ -371,7 +371,6 @@ TypeHandler::find(SystemCatalog::ColDataType typeCode,
case SystemCatalog::NUM_OF_COL_DATA_TYPE:
case SystemCatalog::STRINT:
case SystemCatalog::UNDEFINED:
case SystemCatalog::BINARY:
break;
}
return NULL;
@ -452,7 +451,6 @@ TypeHandler::find_by_ddltype(const ddlpackage::ColumnType &ct)
case ddlpackage::DDL_UNSIGNED_FLOAT: return &mcs_type_handler_ufloat;
case ddlpackage::DDL_UNSIGNED_DOUBLE: return &mcs_type_handler_udouble;
case ddlpackage::DDL_BINARY: //return &mcs_type_handler_binary;
case ddlpackage::DDL_INVALID_DATATYPE:
break;
}

1
datatypes/mcs_datatype.h
View File

@ -154,7 +154,6 @@ public:
LONGDOUBLE, /* @bug3241, dev and variance calculation only */
STRINT, /* @bug3532, string as int for fast comparison */
UNDEFINED, /*!< Undefined - used in UDAF API */
BINARY, /*!< BINARY type */
};
class TypeAttributesStd

29
datatypes/mcs_decimal.h
View File

@ -178,45 +178,24 @@ class Decimal
static inline bool isWideDecimalNullValue(const int128_t& val)
{
const uint64_t* ptr = reinterpret_cast<const uint64_t*>(&val);
return (ptr[0] == utils::BINARYNULLVALUELOW && ptr[1] == utils::BINARYNULLVALUEHIGH);
return (val == TSInt128::NullValue);
}
static inline bool isWideDecimalEmptyValue(const int128_t& val)
{
const uint64_t* ptr = reinterpret_cast<const uint64_t*>(&val);
return (ptr[0] == utils::BINARYEMPTYVALUELOW && ptr[1] == utils::BINARYEMPTYVALUEHIGH);
return (val == TSInt128::EmptyValue);
}
static inline void setWideDecimalNullValue(int128_t& val)
{
uint64_t* ptr = reinterpret_cast<uint64_t*>(&val);
ptr[0] = utils::BINARYNULLVALUELOW;
ptr[1] = utils::BINARYNULLVALUEHIGH;
val = TSInt128::NullValue;
}
static inline void setWideDecimalEmptyValue(int128_t& val)
{
uint64_t* ptr = reinterpret_cast<uint64_t*>(&val);
ptr[0] = utils::BINARYEMPTYVALUELOW;
ptr[1] = utils::BINARYEMPTYVALUEHIGH;
val = TSInt128::EmptyValue;
}
static inline void setWideDecimalNullValue(int128_t* val)
{
uint64_t* ptr = reinterpret_cast<uint64_t*>(val);
ptr[0] = utils::BINARYNULLVALUELOW;
ptr[1] = utils::BINARYNULLVALUEHIGH;
}
static inline void setWideDecimalEmptyValue(int128_t* val)
{
uint64_t* ptr = reinterpret_cast<uint64_t*>(val);
ptr[0] = utils::BINARYEMPTYVALUELOW;
ptr[1] = utils::BINARYEMPTYVALUEHIGH;
}
static constexpr int128_t minInt128 = int128_t(0x8000000000000000LL) << 64;
static constexpr int128_t maxInt128 = (int128_t(0x7FFFFFFFFFFFFFFFLL) << 64) + 0xFFFFFFFFFFFFFFFFLL;