From 43f7a71bad539fecbbeb62d7aa2d17568c4a30b5 Mon Sep 17 00:00:00 2001 From: Patrick LeBlanc Date: Wed, 17 Jul 2019 13:07:08 -0500 Subject: [PATCH] Disable force-killing of StorageManager. Data corruption is possible ATM. --- procmon/processmonitor.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/procmon/processmonitor.cpp b/procmon/processmonitor.cpp index 1faa055c4..4fb6ba9f9 100644 --- a/procmon/processmonitor.cpp +++ b/procmon/processmonitor.cpp @@ -2203,7 +2203,9 @@ int ProcessMonitor::stopProcess(pid_t processID, std::string processName, std::s status = API_SUCCESS; else { - if (actionIndicator == GRACEFUL) + // XXXPAT: StorageManager shouldn't be killed with KILL, or there's a chance of data corruption. + // once we minimize that chance, we could allow KILL to be sent. + if (actionIndicator == GRACEFUL || processName == "StorageManager") { status = kill(processID, SIGTERM); }