From 40194c2f3c3f11e35dc24ddb3717c192e42f3a9a Mon Sep 17 00:00:00 2001
From: David Mott <david.mott@mariadb.com>
Date: Thu, 25 Apr 2019 22:58:17 -0500
Subject: [PATCH] remove unnecessary build target

---
 utils/loggingcpp/CMakeLists.txt | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/utils/loggingcpp/CMakeLists.txt b/utils/loggingcpp/CMakeLists.txt
index c8fbbf2c3..be2a058f9 100644
--- a/utils/loggingcpp/CMakeLists.txt
+++ b/utils/loggingcpp/CMakeLists.txt
@@ -3,16 +3,7 @@ include_directories( ${ENGINE_COMMON_INCLUDES} )
 
 
 ########### next target ###############
-
-set(loggingcpp_LIB_SRCS
-    message.cpp
-    messagelog.cpp
-    logger.cpp
-    errorcodes.cpp
-    sqllogger.cpp
-    stopwatch.cpp
-    idberrorinfo.cpp)
-
+#TODO: put generated files in binary dir
 ADD_CUSTOM_COMMAND(
     OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/messageids.h ${CMAKE_CURRENT_SOURCE_DIR}/errorids.h
     COMMAND /bin/sh genMsgAndErrId.sh
@@ -20,11 +11,20 @@ ADD_CUSTOM_COMMAND(
     DEPENDS genMsgId.pl genErrId.pl
     )
     
-ADD_CUSTOM_TARGET(genMsgAndErrId DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/messageids.h ${CMAKE_CURRENT_SOURCE_DIR}/errorids.h)
     
-add_library(loggingcpp SHARED ${loggingcpp_LIB_SRCS})
+add_library(loggingcpp SHARED
+    message.cpp
+    messagelog.cpp
+    logger.cpp
+    errorcodes.cpp
+    sqllogger.cpp
+    stopwatch.cpp
+    idberrorinfo.cpp
+	${CMAKE_CURRENT_SOURCE_DIR}/messageids.h
+	${CMAKE_CURRENT_SOURCE_DIR}/errorids.h
+	)
+
 
-add_dependencies(loggingcpp genMsgAndErrId)
 
 set_target_properties(loggingcpp PROPERTIES VERSION 1.0.0 SOVERSION 1)