database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

Fix compilation failure on aarch64 with gcc 10.3 Ubuntu 21.04

Browse Source 
According to C++ spec:
If an inline function or variable (since C++17) with external linkage is defined
differently in different translation units, the behavior is undefined.

The undefined behaviour causes link errors for cpimport binary.
/usr/bin/ld: /tmp/cpimport.bin.av067N.ltrans0.ltrans.o:(.data.rel.ro+0x6c8):
undefined reference to `WriteEngine::ColumnOp::isEmptyRow(unsigned long*, unsigned char const*, int)'

The isEmptyRow method is defined as inline in the cpp file and not
inline in the header file. As the method is not used as part of an
external API by any of the callers, nor is it subclassed, mark it as a
normal (non virtual) *inline* member function.
This commit is contained in:
Vicențiu Ciorbaru
2021-11-03 23:14:32 +02:00
committed by Roman Nozdrin
parent 650d45fcc1
commit 342f71e7fb
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
writeengine/wrapper/we_colop.h
View File

@ -221,9 +221,9 @@ public:
/**
* @brief Check whether it is an empty row
*/
EXPORT virtual bool isEmptyRow(uint64_t* curVal,
const uint8_t* emptyVal,
const int colWidth);
inline bool isEmptyRow(uint64_t* curVal,
const uint8_t* emptyVal,
const int colWidth);
/**
* @brief Check whether it is a valid column