1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00

resolved PR comments for cs_package_manager.sh & mcs_backup_manager.sh

This commit is contained in:
Allen Herrera
2024-03-26 13:54:32 -04:00
committed by Alan Mologorsky
parent 66996bec22
commit 2f17c819a2
2 changed files with 53 additions and 29 deletions

View File

@ -255,8 +255,11 @@ check_package_managers() {
fi;
}
check_mac_dependancies() {
# Confirms mac have critical binaries to run this script
# As of 3/2024 mac only supports cs_package_manager.sh check
check_mac_dependencies() {
# Install ggrep if not exists
if ! which ggrep >/dev/null 2>&1; then
echo "Attempting Auto install of ggrep"
@ -267,6 +270,7 @@ check_mac_dependancies() {
brew install grep
fi
# Exit if ggrep still doesnt exist
if ! which ggrep >/dev/null 2>&1; then
echo "Failed to install ggrep"
echo "which ggrep"
@ -278,9 +282,9 @@ check_mac_dependancies() {
check_operating_system() {
if [[ -e "/System/Library/CoreServices/SystemVersion.plist" ]]; then
if [[ $OSTYPE == 'darwin'* ]]; then
echo "Running on macOS"
check_mac_dependancies
check_mac_dependencies
# on action=check - these values are used as triggers to prompt the user to select what OS/version they want to check against
distro_info="mac"
@ -953,6 +957,8 @@ do_install() {
printf "\nDone\n\n"
}
# A quick way for mac users to select an OS when running "cs_package_manager.sh check"
# since theres no /etc/os-release to auto detect what OS & version to search the mariadb repos on mac
prompt_user_for_os() {
# Prompt the user to select an operating system
@ -1011,8 +1017,6 @@ prompt_user_for_os() {
}
do_check() {
check_operating_system