database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-01 06:46:55 +03:00
Code Activity

Silence -Werror=implicit-fallthrough compiler errors - Patch from Monty.

Browse Source 
The patch also fixes some potential bugs due to missing break
statements.
This commit is contained in:
Gagan Goel
2020-06-26 12:28:39 -04:00
parent 31df46168d
commit 2ba9263df4
15 changed files with 25 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
utils/rowgroup/rowaggregation.cpp
View File

@ -1709,6 +1709,7 @@ void RowAggregation::updateEntry(const Row& rowIn)
// if NOT null, let execution fall through.
if (isNull(&fRowGroupIn, rowIn, colIn) == true) break;
/* fall through */
case ROWAGG_COUNT_ASTERISK:
fRow.setUintField<8>(fRow.getUintField<8>(colOut) + 1, colOut);
@ -2467,6 +2468,7 @@ void RowAggregationUM::updateEntry(const Row& rowIn)
// if NOT null, let execution fall through.
if (isNull(&fRowGroupIn, rowIn, colIn) == true) break;
/* fall through */
case ROWAGG_COUNT_ASTERISK:
fRow.setUintField<8>(fRow.getUintField<8>(colOut) + 1, colOut);

1
utils/rowgroup/rowgroup.cpp
View File

@ -744,6 +744,7 @@ void Row::initToNull()
case CalpontSystemCatalog::LONGDOUBLE:
*((long double*) &data[offsets[i]]) = joblist::LONGDOUBLENULL;
break;
case CalpontSystemCatalog::DATETIME:
*((uint64_t*) &data[offsets[i]]) = joblist::DATETIMENULL;