database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

Clang warnfixes (#2310)

Browse Source
This commit is contained in:
Leonid Fedorov
2022-03-21 21:19:55 +03:00
committed by GitHub
parent 14c4840d53
commit 29679e91ec
2 changed files with 7 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
dbcon/joblist/columncommand-jl.h
View File

@ -45,13 +45,13 @@ class ColumnCommandJL : public CommandJL
ColumnCommandJL(const ColumnCommandJL&, const DictStepJL&); ColumnCommandJL(const ColumnCommandJL&, const DictStepJL&);
virtual ~ColumnCommandJL(); virtual ~ColumnCommandJL();
virtual void createCommand(messageqcpp::ByteStream& bs) const; virtual void createCommand(messageqcpp::ByteStream& bs) const override;
virtual void runCommand(messageqcpp::ByteStream& bs) const; virtual void runCommand(messageqcpp::ByteStream& bs) const override;
void setLBID(uint64_t rid, uint32_t dbroot); void setLBID(uint64_t rid, uint32_t dbroot) override;
uint8_t getTableColumnType(); uint8_t getTableColumnType() override;
virtual std::string toString(); virtual std::string toString() override;
uint16_t getWidth(); uint16_t getWidth() override;
CommandType getCommandType() CommandType getCommandType() override
{ {
return COLUMN_COMMAND; return COLUMN_COMMAND;
} }

10
primitives/linux-port/column.cpp
View File

@ -539,16 +539,6 @@ inline bool isNullValue(const T val, const T NULL_VALUE)
return val == NULL_VALUE; return val == NULL_VALUE;
} }
template <>
inline bool isNullValue<KIND_TEXT, int64_t>(const int64_t val, const int64_t NULL_VALUE)
{
//@bug 339 might be a token here
// TODO: what's up with the alternative NULL here?
constexpr const int64_t ALT_NULL_VALUE = 0xFFFFFFFFFFFFFFFELL;
return (val == NULL_VALUE || val == ALT_NULL_VALUE);
}
// //
// FILTER A COLUMN VALUE // FILTER A COLUMN VALUE
// //