database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-4680 FROM subquery containing nested joins returns an error.

Browse Source 
Main theme of the patch is to fix joins processing in the plugin
code. We now use SELECT_LEX::top_join_list and process the nested
joins recursively, instead of SELECT_LEX::table_list struct which
we earlier used to build the join filters. The earlier approach
did not process certain nested join ON expressions, causing certain
queries to incorrectly error out such as that described in MCOL-4680.

In addition, some legacy code is also removed.
This commit is contained in:
Gagan Goel
2021-04-23 05:18:26 -04:00
parent 71c16fcb56
commit 22c7fb7c01
6 changed files with 273 additions and 272 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
dbcon/mysql/ha_view.cpp
View File

@ -44,7 +44,8 @@ using namespace execplan;
namespace cal_impl_if
{
extern uint32_t buildOuterJoin(gp_walk_info& gwi, SELECT_LEX& select_lex);
extern uint32_t buildJoin(gp_walk_info& gwi, List<TABLE_LIST>& join_list,
std::stack<execplan::ParseTree*>& outerJoinStack);
extern string getViewName(TABLE_LIST* table_ptr);
CalpontSystemCatalog::TableAliasName& View::viewName()
@ -182,9 +183,9 @@ void View::transform()
}
}
uint32_t View::processOuterJoin(gp_walk_info& gwi)
uint32_t View::processJoin(gp_walk_info& gwi, std::stack<execplan::ParseTree*>& outerJoinStack)
{
return buildOuterJoin(gwi, fSelect);
return buildJoin(gwi, fSelect.top_join_list, outerJoinStack);
}
}