database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-3343 Error when no group by for unaggregated fields in window functions.

Browse Source
This commit is contained in:
David Hall
2019-06-20 15:54:05 -05:00
parent 4cf2c37c18
commit 2255d41eaf
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
dbcon/joblist/windowfunctionstep.cpp
View File

@ -346,7 +346,10 @@ void WindowFunctionStep::AddSimplColumn(const vector<SimpleColumn*>& scs,
if (scProjected.find(UniqId(*i)) == scProjected.end()) if (scProjected.find(UniqId(*i)) == scProjected.end())
{ {
jobInfo.windowDels.push_back(SRCP((*i)->clone())); jobInfo.windowDels.push_back(SRCP((*i)->clone()));
jobInfo.windowSet.insert(getTupleKey(jobInfo, *i, true)); // MCOL-3343 Enable this if we decide to allow Window Functions to run with
// aggregates with no group by. MariaDB allows this. Nobody else in the world does.
// There will be more work to get it to function if we try this.
// jobInfo.windowSet.insert(getTupleKey(jobInfo, *i, true));
scProjected.insert(UniqId(*i)); scProjected.insert(UniqId(*i));
} }
} }
@ -496,7 +499,10 @@ void WindowFunctionStep::checkWindowFunction(CalpontSelectExecutionPlan* csep, J
if (colSet.find(key) == colSet.end()) if (colSet.find(key) == colSet.end())
{ {
jobInfo.deliveredCols.push_back(*j); jobInfo.deliveredCols.push_back(*j);
jobInfo.windowSet.insert(getTupleKey(jobInfo, *j, true)); // MCOL-3343 Enable this if we decide to allow Window Functions to run with
// aggregates with no group by. MariaDB allows this. Nobody else in the world does.
// There will be more work to get it to function if we try this.
// jobInfo.windowSet.insert(getTupleKey(jobInfo, *j, true));
} }
colSet.insert(key); colSet.insert(key);