database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-10-31 18:30:33 +03:00
Code Activity

chore(plugin): get rid of SELECT_LEX copy asignment calls.

Browse Source
This commit is contained in:
drrtuy
2025-08-06 17:09:21 +00:00
committed by Leonid Fedorov
parent a7e5115ad6
commit 209a9e5082
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
dbcon/mysql/ha_mcs_impl.cpp
View File

@@ -1348,7 +1348,6 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
// Save the item list // Save the item list
List<Item> items; List<Item> items;
SELECT_LEX select_lex;
if (ha_mcs_common::isUpdateStatement(thd->lex->sql_command)) if (ha_mcs_common::isUpdateStatement(thd->lex->sql_command))
{ {
@@ -1356,7 +1355,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
thd->lex->first_select_lex()->item_list = thd->lex->value_list; thd->lex->first_select_lex()->item_list = thd->lex->value_list;
} }
select_lex = *lex->first_select_lex(); SELECT_LEX* select_lex = lex->first_select_lex();
//@Bug 2808 Error out on order by or limit clause //@Bug 2808 Error out on order by or limit clause
//@bug5096. support dml limit. //@bug5096. support dml limit.
@@ -1412,7 +1411,7 @@ uint32_t doUpdateDelete(THD* thd, gp_walk_info& gwi, const std::vector<COND*>& c
gwi.clauseType = WHERE; gwi.clauseType = WHERE;
if (getSelectPlan(gwi, select_lex, updateCP, false, false, false, condStack) != if (getSelectPlan(gwi, *select_lex, updateCP, false, false, false, condStack) !=
0) //@Bug 3030 Modify the error message for unsupported functions 0) //@Bug 3030 Modify the error message for unsupported functions
{ {
if (gwi.cs_vtable_is_update_with_derive) if (gwi.cs_vtable_is_update_with_derive)

3
dbcon/mysql/ha_view.h
View File

@@ -54,7 +54,8 @@ class View
uint32_t processJoin(gp_walk_info& gwi, std::stack<execplan::ParseTree*>&); uint32_t processJoin(gp_walk_info& gwi, std::stack<execplan::ParseTree*>&);
private: private:
SELECT_LEX fSelect; // Lifetime of fSelect is managed by MDB and must be longer than View object
SELECT_LEX& fSelect;
gp_walk_info* fParentGwip; gp_walk_info* fParentGwip;
execplan::CalpontSystemCatalog::TableAliasName fViewName; execplan::CalpontSystemCatalog::TableAliasName fViewName;
}; };