database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

Fix(MCOL-4611): mod loses precision on huge narrow decimal (#3473)

Browse Source
This commit is contained in:
Akhmad Oripov
2025-03-31 15:59:40 +02:00
committed by GitHub
parent 848f5bf162
commit 1bcf63a436
4 changed files with 47 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
mysql-test/columnstore/bugfixes/mcol_4611.result Normal file
View File

@ -0,0 +1,17 @@
DROP DATABASE IF EXISTS mcol_4611;
CREATE DATABASE mcol_4611;
USE mcol_4611;
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a DECIMAL(18,0)) ENGINE=ColumnStore;
INSERT INTO t1 VALUES (999999999999999999);
SELECT a MOD 10000 FROM t1;
a MOD 10000
9999
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a DECIMAL(18,0)) ENGINE=ColumnStore;
INSERT INTO t1 VALUES (999999999999999999);
SELECT RAND(9999), RAND(a MOD 10000) FROM t1;
RAND(9999) RAND(a MOD 10000)
0.7361292641015065 0.7361292641015065
DROP TABLE IF EXISTS t1;
DROP DATABASE mcol_4611;

28
mysql-test/columnstore/bugfixes/mcol_4611.test Normal file
View File

@ -0,0 +1,28 @@
-- source ../include/have_columnstore.inc
--disable_warnings
DROP DATABASE IF EXISTS mcol_4611;
--enable_warnings
CREATE DATABASE mcol_4611;
USE mcol_4611;
--disable_warnings
DROP TABLE IF EXISTS t1;
--enable_warnings
CREATE TABLE t1 (a DECIMAL(18,0)) ENGINE=ColumnStore;
INSERT INTO t1 VALUES (999999999999999999);
SELECT a MOD 10000 FROM t1;
--disable_warnings
DROP TABLE IF EXISTS t1;
--enable_warnings
CREATE TABLE t1 (a DECIMAL(18,0)) ENGINE=ColumnStore;
INSERT INTO t1 VALUES (999999999999999999);
SELECT RAND(9999), RAND(a MOD 10000) FROM t1;
--disable_warnings
DROP TABLE IF EXISTS t1;
--enable_warnings
--disable_warnings
DROP DATABASE mcol_4611;
--enable_warnings

2
utils/funcexp/func_mod.cpp
View File

@ -106,7 +106,7 @@ IDB_Decimal Func_mod::getDecimalVal(Row& row, FunctionParm& parm, bool& isNull,
} }
IDB_Decimal d = parm[0]->data()->getDecimalVal(row, isNull); IDB_Decimal d = parm[0]->data()->getDecimalVal(row, isNull);
int64_t value = d.value / pow(10.0, d.scale); int64_t value = d.value / static_cast<int64_t>(pow(10.0, d.scale));
int lefto = d.value % (int)pow(10.0, d.scale); int lefto = d.value % (int)pow(10.0, d.scale);
int64_t mod = (value % div) * pow(10.0, d.scale) + lefto; int64_t mod = (value % div) * pow(10.0, d.scale) + lefto;

2
utils/funcexp/functor_real.h
View File

@ -381,7 +381,7 @@ class Func_mod : public Func_Real
return static_cast<ModType>(integralRemainder.toTFloat128() + intAndFract.second); return static_cast<ModType>(integralRemainder.toTFloat128() + intAndFract.second);
} }
} }
int64_t value = d.value / pow(10.0, d.scale); int64_t value = d.value / static_cast<int64_t>(pow(10.0, d.scale));
return value % div; return value % div;
} }
}; };