database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

Fix fallthrough compilation warnings

Browse Source
This commit is contained in:
Roman Nozdrin
2020-11-08 14:57:28 +00:00
parent 3eb26c0d4a
commit 15b1bfa709
11 changed files with 24 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
dbcon/execplan/simplecolumn_decimal.h
View File

@ -144,6 +144,7 @@ void SimpleColumn_Decimal<len>::setNullVal()
break;
case 16:
std::cout << __FILE__<< ":" <<__LINE__ << " Fix for 16 Bytes ?" << std::endl;
//fallthrough
default:
fNullVal = joblist::BIGINTNULL;
}

1
dbcon/execplan/simplecolumn_uint.h
View File

@ -144,6 +144,7 @@ void SimpleColumn_UINT<len>::setNullVal()
break;
case 16:
std::cout << __FILE__<< ":" <<__LINE__ << " Fix 16 Bytes ?" << std::endl;
//fallthrough
default:
fNullVal = joblist::UBIGINTNULL;
}

1
dbcon/execplan/windowfunctioncolumn.cpp
View File

@ -491,6 +491,7 @@ void WindowFunctionColumn::evaluate(Row& row, bool& isNull)
break;
case 16:
cout << __FILE__<< ":" <<__LINE__ << " Fix 16 Bytes ?" << endl;
//fallthrough
default:
if (row.equals(CPNULLSTRMARK, fInputIndex))
isNull = true;

1
dbcon/joblist/batchprimitiveprocessor-jl.cpp
View File

@ -682,6 +682,7 @@ void BatchPrimitiveProcessorJL::getTuples(messageqcpp::ByteStream& in,
break;
case 16:
cout << __FILE__<< ":" <<__LINE__ << " Fix 16 Bytes ?" << endl;
//fallthrough
default:
cout << "BPP::getTuples(): bad column width of " << colWidths[j]
<< endl;

1
dbcon/joblist/columncommand-jl.cpp
View File

@ -271,6 +271,7 @@ uint8_t ColumnCommandJL::getTableColumnType()
return TableColumn::UINT8;
case 16:
cout << __FILE__<< ":" <<__LINE__ << " Fix 16 Bytes ?" << endl;
//fallthrough
default:
throw logic_error("ColumnCommandJL: bad column width");
}

4
dbcon/joblist/rowestimator.cpp
View File

@ -384,8 +384,8 @@ float RowEstimator::estimateRowReturnFactor(const BRM::EMEntry& emEntry,
bigValue = static_cast<int128_t>(val);
break;
}
/* fall through */
}
// fallthrough
case 8:
default:
@ -430,8 +430,8 @@ float RowEstimator::estimateRowReturnFactor(const BRM::EMEntry& emEntry,
bigValue = static_cast<int128_t>(val);
break;
}
/* fall through */
}
// fallthrough
case 8:
default:

4
primitives/linux-port/column.cpp
View File

@ -766,7 +766,7 @@ inline void store(const NewColRequestHeader* in,
default:
std::cout << __func__ << " WARNING!!! unspecified column width." << std::endl;
[[fallthrough]];
// fallthrough
case 8:
ptr2 += (rid << 3);
@ -1840,7 +1840,7 @@ void PrimitiveProcessor::p_Col(NewColRequestHeader* in, NewColResultHeader* out,
case 32:
std::cout << __func__ << " WARNING!!! Not implemented for 32 byte data types." << std::endl;
[[fallthrough]];
// fallthrough
default:
idbassert(0);

4
utils/rowgroup/rowgroup.cpp
View File

@ -648,7 +648,7 @@ string Row::toString() const
os << buf << " ";
break;
}
// fallthrough if the legacy DECIMAL
//fallthrough
default:
os << getIntField(i) << " ";
break;
@ -712,6 +712,7 @@ string Row::toCSV() const
}
case CalpontSystemCatalog::BINARY:
std::cout << __FILE__<< __LINE__ << ":" << "toCSV"<< std::endl;
//fallthrough
default:
os << getIntField(i);
@ -1789,6 +1790,7 @@ void RowGroup::addToSysDataList(execplan::CalpontSystemCatalog::NJLSysDataList&
case CalpontSystemCatalog::BINARY:
std::cout << __FILE__<< __LINE__ << __func__<< std::endl;
//fallthrough
default:
cr->PutData(row.getIntField<8>(j));
}

3
utils/windowfunction/wf_udaf.cpp
View File

@ -493,6 +493,7 @@ bool WF_udaf::dropValues(int64_t b, int64_t e)
}
case CalpontSystemCatalog::BINARY:
cout << __FILE__<< ":" <<__LINE__ << " Fix for 16 Bytes ?" << endl;
//fallthrough
default:
{
string errStr = "(" + colType2String[(int)datum.dataType] + ")";
@ -769,6 +770,7 @@ void WF_udaf::SetUDAFValue(static_any::any& valOut, int64_t colOut,
break;
case CalpontSystemCatalog::BINARY:
cout << __FILE__<< ":" <<__LINE__ << " Fix for 16 Bytes ?" << endl;
//fallthrough
default:
{
std::ostringstream errmsg;
@ -1150,6 +1152,7 @@ void WF_udaf::operator()(int64_t b, int64_t e, int64_t c)
}
case CalpontSystemCatalog::BINARY:
cout << __FILE__<< ":" <<__LINE__ << " Fix for 16 Bytes ?" << endl;
//fallthrough
default:
{
string errStr = "(" + colType2String[(int)datum.dataType] + ")";

1
utils/windowfunction/windowfunctiontype.cpp
View File

@ -802,6 +802,7 @@ void* WindowFunctionType::getNullValueByType(int ct, int pos)
break;
case CalpontSystemCatalog::BINARY:
cout << __FILE__<< ":" <<__LINE__ << " Fix for 16 Bytes ?" << endl;
//fallthrough
case CalpontSystemCatalog::VARBINARY:
default:
std::ostringstream oss;

2
writeengine/server/we_dmlcommandproc.cpp
View File

@ -3006,7 +3006,6 @@ uint8_t WE_DMLCommandProc::processUpdate(messageqcpp::ByteStream& bs,
break;
}
[[fallthrough]];
}
/* fall through */
@ -3369,7 +3368,6 @@ uint8_t WE_DMLCommandProc::processUpdate(messageqcpp::ByteStream& bs,
break;
}
[[fallthrough]];
}
/* fall through */