database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-11-03 17:13:17 +03:00
Code Activity

Tracing fixes:

Browse Source 
Don't log trace_params in tracing logger, because it already has all this data
Don't print span attrs, it can contain lots of headers
Save small part of the response into the span, if the response was a JSON string
Added JSON logging of trace details into a separate file (to not spam the main log with machine readable stuff)
Record part of the response into the span
Set duration attribute in server spans
Log 404 errors
Colorize the traces (each span slightly changes the color of the parent span)
Improve trace visualization with duration formatting and notes for request/response pairs
This commit is contained in:
Alexander Presnyakov
2025-09-04 17:21:25 +00:00
parent 194e7ccbdc
commit 151903cd18
13 changed files with 962 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cmapi/tracing/trace_tool.py
View File

@@ -8,7 +8,6 @@ import cherrypy
from tracing.tracer import get_tracer
def _on_request_start() -> None:
req = cherrypy.request
tracer = get_tracer()
@@ -22,20 +21,27 @@ def _on_request_start() -> None:
trace_id, parent_span_id = tracer.extract_traceparent(headers)
tracer.set_incoming_context(trace_id, parent_span_id)
span_name = f"{getattr(req, 'method', 'HTTP')} {getattr(req, 'path_info', '/')}"
requester_host = getattr(getattr(req, 'remote', None), 'ip', '')
method = getattr(req, 'method', 'HTTP')
path = getattr(req, 'path_info', '/')
if requester_host:
span_name = f"{requester_host} --> {method} {path}"
else:
span_name = f"{method} {path}"
ctx = tracer.start_as_current_span(span_name, kind="SERVER")
span = ctx.__enter__()
span.set_attribute('http.method', getattr(req, 'method', ''))
span.set_attribute('http.path', getattr(req, 'path_info', ''))
span.set_attribute('client.ip', getattr(getattr(req, 'remote', None), 'ip', ''))
span.set_attribute('client.ip', requester_host)
span.set_attribute('instance.hostname', socket.gethostname())
safe_headers = {k: v for k, v in headers.items() if k.lower() not in {'authorization', 'x-api-key'}}
span.set_attribute('sentry.incoming_headers', safe_headers)
req._trace_span_ctx = ctx
req._trace_span = span
tracer.inject_traceparent(cherrypy.response.headers) # type: ignore[arg-type]
tracer.inject_traceparent(cherrypy.response.headers)
def _on_request_end() -> None: