database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

For INSERT ... SELECT, don't use the is_cache_insert flag

Browse Source 
when starting bulk insert. This will invoke cpimport for
the query instead of batch inserts mode. This is intentional
as batch inserts currently have an edge case mentioned in
MCOL-4037 that needs to be fixed.
This commit is contained in:
Gagan Goel
2020-06-03 20:35:44 -04:00
parent dd9372c4e8
commit 1216f9fc70
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
dbcon/mysql/ha_mcs.cpp
View File

@ -1329,7 +1329,8 @@ ha_mcs_cache::ha_mcs_cache(handlerton *hton, TABLE_SHARE *table_arg, MEM_ROOT *m
ha_mcs_cache::~ha_mcs_cache() ha_mcs_cache::~ha_mcs_cache()
{ {
delete cache_handler; if (cache_handler)
delete cache_handler;
} }
/* /*
@ -1593,7 +1594,7 @@ void ha_mcs_cache::start_bulk_insert(ha_rows rows, uint flags)
bzero(&cache_handler->copy_info, sizeof(cache_handler->copy_info)); bzero(&cache_handler->copy_info, sizeof(cache_handler->copy_info));
return cache_handler->start_bulk_insert(rows, flags); return cache_handler->start_bulk_insert(rows, flags);
} }
return parent::start_bulk_insert_from_cache(rows, flags); return parent::start_bulk_insert(rows, flags);
} }