You've already forked mariadb-columnstore-engine
mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-07-30 19:23:07 +03:00
chore(codestyle): mark virtual methods as override
This commit is contained in:
Aleksei Antipovskii
committed by
Leonid Fedorov
Leonid Fedorov
parent
ad80ab40aa
commit
0ab03c7258
@ -49,7 +49,7 @@ class reservablePQ : private std::priority_queue<_Tp, _Sequence, _Compare>
|
||||
{
|
||||
public:
|
||||
typedef typename std::priority_queue<_Tp, _Sequence, _Compare>::size_type size_type;
|
||||
reservablePQ(size_type capacity = 0)
|
||||
explicit reservablePQ(size_type capacity = 0)
|
||||
{
|
||||
reserve(capacity);
|
||||
};
|
||||
@ -98,12 +98,10 @@ struct IdbSortSpec
|
||||
class Compare
|
||||
{
|
||||
public:
|
||||
Compare(const IdbSortSpec& spec) : fSpec(spec)
|
||||
{
|
||||
}
|
||||
virtual ~Compare()
|
||||
explicit Compare(const IdbSortSpec& spec) : fSpec(spec)
|
||||
{
|
||||
}
|
||||
virtual ~Compare() = default;
|
||||
|
||||
virtual int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) = 0;
|
||||
void revertSortSpec()
|
||||
@ -121,41 +119,41 @@ class Compare
|
||||
class TinyIntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
TinyIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit TinyIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class SmallIntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
SmallIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit SmallIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class IntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
IntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit IntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class BigIntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
BigIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit BigIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class WideDecimalCompare : public Compare
|
||||
@ -167,7 +165,7 @@ class WideDecimalCompare : public Compare
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
// End of comparators for signed types
|
||||
@ -176,41 +174,41 @@ class WideDecimalCompare : public Compare
|
||||
class UTinyIntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
UTinyIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit UTinyIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class USmallIntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
USmallIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit USmallIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class UIntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
UIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit UIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class UBigIntCompare : public Compare
|
||||
{
|
||||
public:
|
||||
UBigIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit UBigIntCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
// end of comparators for unsigned types
|
||||
@ -220,31 +218,31 @@ class UBigIntCompare : public Compare
|
||||
class DoubleCompare : public Compare
|
||||
{
|
||||
public:
|
||||
DoubleCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit DoubleCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class LongDoubleCompare : public Compare
|
||||
{
|
||||
public:
|
||||
LongDoubleCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit LongDoubleCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class FloatCompare : public Compare
|
||||
{
|
||||
public:
|
||||
FloatCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit FloatCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
// End of comparators for float types
|
||||
@ -253,31 +251,31 @@ class FloatCompare : public Compare
|
||||
class DateCompare : public Compare
|
||||
{
|
||||
public:
|
||||
DateCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit DateCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class DatetimeCompare : public Compare
|
||||
{
|
||||
public:
|
||||
DatetimeCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit DatetimeCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
class TimeCompare : public Compare
|
||||
{
|
||||
public:
|
||||
TimeCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
explicit TimeCompare(const IdbSortSpec& spec) : Compare(spec)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
};
|
||||
|
||||
// End of comparators for temporal types
|
||||
@ -287,11 +285,11 @@ class TimeCompare : public Compare
|
||||
class StringCompare : public Compare
|
||||
{
|
||||
public:
|
||||
StringCompare(const IdbSortSpec& spec) : Compare(spec), cs(NULL)
|
||||
explicit StringCompare(const IdbSortSpec& spec) : Compare(spec), cs(nullptr)
|
||||
{
|
||||
}
|
||||
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
int operator()(IdbCompare*, rowgroup::Row::Pointer, rowgroup::Row::Pointer) override;
|
||||
|
||||
CHARSET_INFO* cs;
|
||||
};
|
||||
@ -301,7 +299,7 @@ class StringCompare : public Compare
|
||||
class CompareRule
|
||||
{
|
||||
public:
|
||||
CompareRule(IdbCompare* c = NULL) : fIdbCompare(c)
|
||||
explicit CompareRule(IdbCompare* c = nullptr) : fIdbCompare(c)
|
||||
{
|
||||
}
|
||||
|
||||
@ -317,8 +315,8 @@ class CompareRule
|
||||
class IdbCompare
|
||||
{
|
||||
public:
|
||||
IdbCompare(){};
|
||||
virtual ~IdbCompare(){};
|
||||
IdbCompare() = default;
|
||||
virtual ~IdbCompare() = default;
|
||||
|
||||
virtual void initialize(const rowgroup::RowGroup&);
|
||||
void setStringTable(bool b);
|
||||
@ -362,7 +360,7 @@ class OrderByRow
|
||||
class EqualCompData : public IdbCompare
|
||||
{
|
||||
public:
|
||||
EqualCompData(std::vector<uint64_t>& v) : fIndex(v)
|
||||
explicit EqualCompData(std::vector<uint64_t>& v) : fIndex(v)
|
||||
{
|
||||
}
|
||||
EqualCompData(std::vector<uint64_t>& v, const rowgroup::RowGroup& rg) : fIndex(v)
|
||||
@ -370,7 +368,7 @@ class EqualCompData : public IdbCompare
|
||||
initialize(rg);
|
||||
}
|
||||
|
||||
~EqualCompData(){};
|
||||
~EqualCompData() override = default;
|
||||
|
||||
bool operator()(rowgroup::Row::Pointer, rowgroup::Row::Pointer);
|
||||
|
||||
@ -381,7 +379,7 @@ class OrderByData : public IdbCompare
|
||||
{
|
||||
public:
|
||||
OrderByData(const std::vector<IdbSortSpec>&, const rowgroup::RowGroup&);
|
||||
virtual ~OrderByData();
|
||||
~OrderByData() override;
|
||||
|
||||
bool operator()(rowgroup::Row::Pointer p1, rowgroup::Row::Pointer p2)
|
||||
{
|
||||
@ -401,9 +399,9 @@ class IdbOrderBy : public IdbCompare
|
||||
{
|
||||
public:
|
||||
IdbOrderBy();
|
||||
virtual ~IdbOrderBy();
|
||||
~IdbOrderBy() override;
|
||||
|
||||
virtual void initialize(const rowgroup::RowGroup&);
|
||||
void initialize(const rowgroup::RowGroup&) override;
|
||||
virtual void processRow(const rowgroup::Row&) = 0;
|
||||
virtual uint64_t getKeyLength() const = 0;
|
||||
virtual const std::string toString() const = 0;
|
||||
|
||||
Reference in New Issue
Block a user