You've already forked mariadb-columnstore-engine
mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-07-30 19:23:07 +03:00
chore(codestyle): mark virtual methods as override
This commit is contained in:
committed by
Leonid Fedorov
parent
ad80ab40aa
commit
0ab03c7258
@ -71,20 +71,18 @@ typedef std::tr1::unordered_map<DATATYPE, uint32_t> MODE_DATA;
|
||||
// Override UserData for data storage
|
||||
struct ModeData : public UserData
|
||||
{
|
||||
ModeData(){};
|
||||
ModeData() = default;
|
||||
|
||||
virtual ~ModeData()
|
||||
{
|
||||
}
|
||||
~ModeData() override = default;
|
||||
|
||||
virtual void serialize(messageqcpp::ByteStream& bs) const;
|
||||
virtual void unserialize(messageqcpp::ByteStream& bs);
|
||||
void serialize(messageqcpp::ByteStream& bs) const override;
|
||||
void unserialize(messageqcpp::ByteStream& bs) override;
|
||||
|
||||
MODE_DATA mData;
|
||||
|
||||
private:
|
||||
// For now, copy construction is unwanted
|
||||
ModeData(UserData&);
|
||||
explicit ModeData(UserData&);
|
||||
};
|
||||
|
||||
// Override mcsv1_UDAF to build your User Defined Aggregate (UDAF) and/or
|
||||
@ -104,7 +102,7 @@ class avg_mode : public mcsv1_UDAF
|
||||
public:
|
||||
// Defaults OK
|
||||
avg_mode() : mcsv1_UDAF(){};
|
||||
virtual ~avg_mode(){};
|
||||
~avg_mode() override = default;
|
||||
|
||||
/**
|
||||
* init()
|
||||
@ -124,7 +122,7 @@ class avg_mode : public mcsv1_UDAF
|
||||
* colTypes or wrong number of arguments. Else return
|
||||
* mcsv1_UDAF::SUCCESS.
|
||||
*/
|
||||
virtual ReturnCode init(mcsv1Context* context, ColumnDatum* colTypes);
|
||||
ReturnCode init(mcsv1Context* context, ColumnDatum* colTypes) override;
|
||||
|
||||
/**
|
||||
* reset()
|
||||
@ -139,7 +137,7 @@ class avg_mode : public mcsv1_UDAF
|
||||
*
|
||||
* Use this opportunity to initialize the userData.
|
||||
*/
|
||||
virtual ReturnCode reset(mcsv1Context* context);
|
||||
ReturnCode reset(mcsv1Context* context) override;
|
||||
|
||||
/**
|
||||
* nextValue()
|
||||
@ -159,7 +157,7 @@ class avg_mode : public mcsv1_UDAF
|
||||
*
|
||||
* valsIn (in) - a vector of the parameters from the row.
|
||||
*/
|
||||
virtual ReturnCode nextValue(mcsv1Context* context, ColumnDatum* valsIn);
|
||||
ReturnCode nextValue(mcsv1Context* context, ColumnDatum* valsIn) override;
|
||||
|
||||
/**
|
||||
* subEvaluate()
|
||||
@ -186,7 +184,7 @@ class avg_mode : public mcsv1_UDAF
|
||||
* as seen in the last call to NextValue for a given PM.
|
||||
*
|
||||
*/
|
||||
virtual ReturnCode subEvaluate(mcsv1Context* context, const UserData* valIn);
|
||||
ReturnCode subEvaluate(mcsv1Context* context, const UserData* valIn) override;
|
||||
|
||||
/**
|
||||
* evaluate()
|
||||
@ -207,7 +205,7 @@ class avg_mode : public mcsv1_UDAF
|
||||
*
|
||||
* To return a NULL value, don't assign to valOut.
|
||||
*/
|
||||
virtual ReturnCode evaluate(mcsv1Context* context, static_any::any& valOut);
|
||||
ReturnCode evaluate(mcsv1Context* context, static_any::any& valOut) override;
|
||||
|
||||
/**
|
||||
* dropValue()
|
||||
@ -235,7 +233,7 @@ class avg_mode : public mcsv1_UDAF
|
||||
* dropValue() will not be called for unbounded/current row type
|
||||
* frames, as those are already optimized.
|
||||
*/
|
||||
virtual ReturnCode dropValue(mcsv1Context* context, ColumnDatum* valsDropped);
|
||||
ReturnCode dropValue(mcsv1Context* context, ColumnDatum* valsDropped) override;
|
||||
|
||||
/**
|
||||
* createUserData()
|
||||
@ -260,11 +258,11 @@ class avg_mode : public mcsv1_UDAF
|
||||
* memory leaks are your fault.
|
||||
*
|
||||
*/
|
||||
virtual ReturnCode createUserData(UserData*& data, int32_t& length);
|
||||
ReturnCode createUserData(UserData*& data, int32_t& length) override;
|
||||
|
||||
protected:
|
||||
};
|
||||
|
||||
}; // namespace mcsv1sdk
|
||||
} // namespace mcsv1sdk
|
||||
|
||||
#undef EXPORT
|
||||
|
Reference in New Issue
Block a user