1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00

chore(codestyle): mark virtual methods as override

This commit is contained in:
Aleksei Antipovskii
2024-09-12 12:27:02 +02:00
committed by Leonid Fedorov
parent ad80ab40aa
commit 0ab03c7258
303 changed files with 4085 additions and 4886 deletions

View File

@ -27,19 +27,19 @@ namespace idbdatafile
class SMDataFile : public IDBDataFile
{
public:
virtual ~SMDataFile();
~SMDataFile() override;
ssize_t pread(void* ptr, off64_t offset, size_t count);
ssize_t read(void* ptr, size_t count);
ssize_t write(const void* ptr, size_t count);
int seek(off64_t offset, int whence);
int truncate(off64_t length);
int fallocate(int mode, off64_t offset, off64_t length);
off64_t size();
off64_t tell();
int flush();
time_t mtime();
int close();
ssize_t pread(void* ptr, off64_t offset, size_t count) override;
ssize_t read(void* ptr, size_t count) override;
ssize_t write(const void* ptr, size_t count) override;
int seek(off64_t offset, int whence) override;
int truncate(off64_t length) override;
int fallocate(int mode, off64_t offset, off64_t length) override;
off64_t size() override;
off64_t tell() override;
int flush() override;
time_t mtime() override;
int close() override;
// for testing only
SMDataFile(const char* fname, int openmode, size_t fake_size);

View File

@ -25,7 +25,7 @@ namespace idbdatafile
class SMFileFactory : public FileFactoryBase
{
public:
IDBDataFile* open(const char* fname, const char* mode, unsigned opts, unsigned colWidth);
IDBDataFile* open(const char* fname, const char* mode, unsigned opts, unsigned colWidth) override;
};
} // namespace idbdatafile

View File

@ -28,20 +28,20 @@ class SMFileSystem : public IDBFileSystem, boost::noncopyable
{
public:
SMFileSystem();
virtual ~SMFileSystem();
~SMFileSystem() override;
// why are some of these const and some not const in IDBFileSystem?
int mkdir(const char* pathname);
off64_t size(const char* path) const;
off64_t compressedSize(const char* path) const;
int remove(const char* pathname);
int rename(const char* oldpath, const char* newpath);
bool exists(const char* pathname) const;
int listDirectory(const char* pathname, std::list<std::string>& contents) const;
bool isDir(const char* pathname) const;
int copyFile(const char* srcPath, const char* destPath) const;
bool filesystemIsUp() const;
bool filesystemSync() const;
int mkdir(const char* pathname) override;
off64_t size(const char* path) const override;
off64_t compressedSize(const char* path) const override;
int remove(const char* pathname) override;
int rename(const char* oldpath, const char* newpath) override;
bool exists(const char* pathname) const override;
int listDirectory(const char* pathname, std::list<std::string>& contents) const override;
bool isDir(const char* pathname) const override;
int copyFile(const char* srcPath, const char* destPath) const override;
bool filesystemIsUp() const override;
bool filesystemSync() const override;
};
} // namespace idbdatafile

View File

@ -24,7 +24,7 @@ namespace idbdatafile
class NotImplementedYet : public std::logic_error
{
public:
NotImplementedYet(const std::string& s);
explicit NotImplementedYet(const std::string& s);
};
NotImplementedYet::NotImplementedYet(const std::string& s) : std::logic_error(s)