database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-2230 Fix TIMEDIFF() handling

Browse Source 
TIMEDIFF would not compare datetime with string correctly, causing a
NULL saturation.
This commit is contained in:
Andrew Hutchings
2019-06-10 16:46:24 +01:00
parent f8b834c8ec
commit 0983c1becf
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
utils/funcexp/func_timediff.cpp
View File

@ -118,7 +118,10 @@ string Func_timediff::getStrVal(rowgroup::Row& row,
case execplan::CalpontSystemCatalog::TIME: case execplan::CalpontSystemCatalog::TIME:
case execplan::CalpontSystemCatalog::DATETIME: case execplan::CalpontSystemCatalog::DATETIME:
if (type1 != type2) // Diff between time and datetime returns NULL in MariaDB
if ((type2 == execplan::CalpontSystemCatalog::TIME ||
type2 == execplan::CalpontSystemCatalog::DATETIME) &&
type1 != type2)
{ {
isNull = true; isNull = true;
break; break;