From 5e249249940a5a15356c7da3e900b705020885fd Mon Sep 17 00:00:00 2001 From: kaleb-himes Date: Wed, 14 Oct 2026 14:30:08 -0600 Subject: [PATCH] Fix MSVC C4018 signed/unsigned compares in SLH-DSA key export --- wolfcrypt/src/wc_slhdsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wolfcrypt/src/wc_slhdsa.c b/wolfcrypt/src/wc_slhdsa.c index 964a2f14b4..8041cf5539 100644 --- a/wolfcrypt/src/wc_slhdsa.c +++ b/wolfcrypt/src/wc_slhdsa.c @@ -11203,7 +11203,7 @@ int wc_SlhDsaKey_ExportPrivate(SlhDsaKey* key, byte* priv, word32* privLen) ret = MISSING_KEY; } /* Check private key buffer length. */ - else if (*privLen < key->params->n * 4) { + else if (*privLen < (word32)key->params->n * 4U) { ret = BAD_LENGTH_E; } else { @@ -11243,7 +11243,7 @@ int wc_SlhDsaKey_ExportPublic(SlhDsaKey* key, byte* pub, word32* pubLen) ret = MISSING_KEY; } /* Check public key buffer length. */ - else if (*pubLen < key->params->n * 2) { + else if (*pubLen < (word32)key->params->n * 2U) { ret = BAD_LENGTH_E; } else {