crypt/step-ca-cli
1
0
Fork 0
mirror of https://github.com/smallstep/cli.git synced 2025-08-09 03:22:43 +03:00
Code Activity

Fixes #29: skip or log unexpected requests to the oauth server.

Browse Source 
Returns 404 for requests to invalid paths.
Add error messages to unexpected requests to /.
This commit is contained in:
Mariano Cano
2018-10-01 11:59:11 -07:00
parent 2609703bcb
commit 558e5e8c0e
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
command/oauth/cmd.go
View File

@@ -551,6 +551,11 @@ func (o *oauth) DoJWTAuthorization(issuer, aud string) (*token, error) {
// ServeHTTP is the handler that performs the OAuth 2.0 dance and returns the
// tokens using channels.
func (o *oauth) ServeHTTP(w http.ResponseWriter, req *http.Request) {
if req.URL.Path != "/" {
http.NotFound(w, req)
return
}
q := req.URL.Query()
errStr := q.Get("error")
if errStr != "" {
@@ -559,12 +564,11 @@ func (o *oauth) ServeHTTP(w http.ResponseWriter, req *http.Request) {
}
code, state := q.Get("code"), q.Get("state")
if code == "" || state == "" {
fmt.Printf("Invalid request received from: %v%v\n\n", req.RemoteAddr, req.RequestURI)
if req.RequestURI == "/robots.txt" {
fmt.Printf("** You may have an app or browser plugin that needs to be turned off **\n\n")
}
fmt.Fprintf(os.Stderr, "Invalid request received: http://%s%s\n", req.RemoteAddr, req.URL.String())
fmt.Fprintf(os.Stderr, "You may have an app or browser plugin that needs to be turned off\n")
http.Error(w, "400 bad request", http.StatusBadRequest)
return
}
if code == "" {