mirror of
https://github.com/certbot/certbot.git
synced 2026-01-26 07:41:33 +03:00
* helpful: fix handling of abbreviated ConfigArgparse arguments (#9796) * helpful: fix handling of abbreviated ConfigArgparse arguments ConfigArgparse allows for "abbreviated" arguments, i.e. just the prefix of an argument, but it doesn't set the argument sources in these cases. This commit checks for those cases and sets the sources appropriately. * failing to find an action raises an error instead of logging * Update changelog * Add handling for short arguments, fix equals sign handling These were silently being dropped before, possibly leading to instances of `NamespaceConfig.set_by_user()` returning false negatives. (cherry picked from commit11e17ef77b) * Fix finish_release.py (#9800) * response is value * rename vars (cherry picked from commita96fb4b6ce) * Merge pull request #9762 from certbot/docs/yaml-config Add YAML files for Readthedocs requirements (cherry picked from commit44046c70c3) * Update Lexicon requirements to stabilize certbot-dns-ovh behavior (#9802) * Update minimum Lexicon version required for certbot-dns-ovh * Add types * FIx mypy * Fix lint * Fix BOTH lint and mypy (cherry picked from commit5cf5f36f19) * simplify code (#9807) (cherry picked from commit6f7b5ab1cd) * Include linting fixes from8a95c03--------- Co-authored-by: Will Greenberg <willg@eff.org> Co-authored-by: Alexis <alexis@eff.org> Co-authored-by: Adrien Ferrand <adferrand@users.noreply.github.com>
215 lines
7.8 KiB
Python
Executable File
215 lines
7.8 KiB
Python
Executable File
#!/usr/bin/env python
|
|
"""
|
|
Post-release script to publish artifacts created from Azure Pipelines.
|
|
|
|
This currently includes:
|
|
|
|
* Moving snaps from the beta channel to the stable channel
|
|
* Publishing the Windows installer in a GitHub release
|
|
|
|
Setup:
|
|
- Install the snapcraft command line tool and log in to a privileged account.
|
|
- https://snapcraft.io/docs/installing-snapcraft
|
|
- Use the command `snapcraft login` to log in.
|
|
|
|
Run:
|
|
|
|
python tools/finish_release.py --css <URL of code signing server>
|
|
|
|
Testing:
|
|
|
|
This script can be safely run between releases. When this is done, the script
|
|
should execute successfully until the final step when it tries to set draft
|
|
equal to false on the GitHub release. This step should fail because a published
|
|
release with that name already exists.
|
|
|
|
"""
|
|
|
|
import argparse
|
|
import getpass
|
|
import glob
|
|
import os.path
|
|
import re
|
|
import subprocess
|
|
import sys
|
|
import tempfile
|
|
from zipfile import ZipFile
|
|
|
|
from azure.devops.connection import Connection
|
|
import requests
|
|
|
|
# Path to the root directory of the Certbot repository containing this script
|
|
REPO_ROOT = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
|
|
# This list contains the names of all Certbot DNS plugins. We used to have a
|
|
# CloudXNS plugin and since it's possible devs still have that directory
|
|
# locally, we filter it out here. If it's included in this list, this script
|
|
# will crash later when it fails to find a CloudXNS snap on the snap store with
|
|
# the current version since we no longer build it.
|
|
PLUGIN_SNAPS = [os.path.basename(path)
|
|
for path in glob.glob(os.path.join(REPO_ROOT, 'certbot-dns-*'))
|
|
if not path.endswith('certbot-dns-cloudxns')]
|
|
# This list contains the name of all Certbot snaps that should be published to
|
|
# the stable channel.
|
|
ALL_SNAPS = ['certbot'] + PLUGIN_SNAPS
|
|
# This is the count of the architectures currently supported by our snaps used
|
|
# for sanity checking.
|
|
SNAP_ARCH_COUNT = 3
|
|
|
|
|
|
def parse_args(args):
|
|
"""Parse command line arguments.
|
|
|
|
:param args: command line arguments with the program name removed. This is
|
|
usually taken from sys.argv[1:].
|
|
:type args: `list` of `str`
|
|
|
|
:returns: parsed arguments
|
|
:rtype: argparse.Namespace
|
|
|
|
"""
|
|
# Use the file's docstring for the help text and don't let argparse reformat it.
|
|
parser = argparse.ArgumentParser(description=__doc__,
|
|
formatter_class=argparse.RawDescriptionHelpFormatter)
|
|
parser.add_argument('--css', type=str, required=True, help='hostname of code signing server')
|
|
return parser.parse_args(args)
|
|
|
|
|
|
def publish_windows(css):
|
|
"""SSH into CSS and trigger downloading Azure Pipeline assets, sign, and upload to Github
|
|
|
|
:param str css: CSS host name
|
|
|
|
"""
|
|
username = input("CSS username (usually EFF username): ")
|
|
host = css
|
|
command = "ssh -t {}@{} bash /opt/certbot-misc/css/venv.sh".format(username,host)
|
|
|
|
print("SSH into CSS to trigger signing and uploading of Windows installer...")
|
|
subprocess.run(command, check=True, universal_newlines=True, shell=True)
|
|
|
|
|
|
def assert_logged_into_snapcraft():
|
|
"""Confirms that snapcraft is logged in to an account.
|
|
|
|
:raises SystemExit: if the command snapcraft is unavailable or it
|
|
isn't logged into an account
|
|
|
|
"""
|
|
cmd = 'snapcraft whoami'.split()
|
|
try:
|
|
subprocess.run(cmd, check=True, stdout=subprocess.DEVNULL,
|
|
stderr=subprocess.DEVNULL, universal_newlines=True)
|
|
except (subprocess.CalledProcessError, OSError):
|
|
print("Please make sure that the command line tool snapcraft is")
|
|
print("installed and that you have logged in to an account by running")
|
|
print("'snapcraft login'.")
|
|
sys.exit(1)
|
|
|
|
|
|
def get_snap_revisions(snap, channel, version):
|
|
"""Finds the revisions for the snap and version in the given channel.
|
|
|
|
If you call this function without being logged in with snapcraft, it
|
|
will hang with no output.
|
|
|
|
:param str snap: the name of the snap on the snap store
|
|
:param str channel: snap channel to pull revisions from
|
|
:param str version: snap version number, e.g. 1.7.0
|
|
|
|
:returns: list of revision numbers
|
|
:rtype: `list` of `str`
|
|
|
|
:raises subprocess.CalledProcessError: if the snapcraft command
|
|
fails
|
|
|
|
:raises AssertionError: if the expected snaps are not found
|
|
|
|
"""
|
|
print('Getting revision numbers for', snap, version)
|
|
cmd = ['snapcraft', 'status', snap]
|
|
process = subprocess.run(cmd, check=True, stdout=subprocess.PIPE, universal_newlines=True)
|
|
pattern = f'^\s+{channel}\s+{version}\s+(\d+)\s*'
|
|
revisions = re.findall(pattern, process.stdout, re.MULTILINE)
|
|
assert len(revisions) == SNAP_ARCH_COUNT, f'Unexpected number of snaps found for {channel} {snap} {version} (expected {SNAP_ARCH_COUNT}, found {len(revisions)})'
|
|
return revisions
|
|
|
|
|
|
def promote_snaps(snaps, source_channel, version, progressive_percentage=None):
|
|
"""Promotes the given snaps from source_channel to the stable channel.
|
|
|
|
If the snaps have already been released to the stable channel, this
|
|
function will try to release them again which has no effect.
|
|
|
|
:param snaps: snap package names to be promoted
|
|
:type snaps: `list` of `str`
|
|
:param str source_channel: snap channel to promote from
|
|
:param str version: the version number that should be found in the
|
|
candidate channel, e.g. 1.7.0
|
|
:param progressive_percentage: specifies the percentage of a progressive
|
|
deployment
|
|
:type progressive_percentage: int or None
|
|
|
|
:raises SystemExit: if the command snapcraft is unavailable or it
|
|
isn't logged into an account
|
|
|
|
:raises subprocess.CalledProcessError: if a snapcraft command fails
|
|
for another reason
|
|
|
|
"""
|
|
assert_logged_into_snapcraft()
|
|
for snap in snaps:
|
|
revisions = get_snap_revisions(snap, source_channel, version)
|
|
# The loop below is kind of slow, so let's print some output about what
|
|
# it is doing.
|
|
print('Releasing', snap, 'snaps to the stable channel')
|
|
for revision in revisions:
|
|
cmd = ['snapcraft', 'release', snap, revision, 'stable']
|
|
if progressive_percentage:
|
|
cmd.extend(f'--progressive {progressive_percentage}'.split())
|
|
try:
|
|
subprocess.run(cmd, check=True, stdout=subprocess.PIPE, universal_newlines=True)
|
|
except subprocess.CalledProcessError as e:
|
|
print("The command", f"'{' '.join(cmd)}'", "failed.")
|
|
print("The output printed to stdout was:")
|
|
print(e.stdout)
|
|
raise
|
|
|
|
def fetch_version_number(major_version=None):
|
|
"""Retrieve version number for release from Azure Pipelines
|
|
|
|
:param major_version: only consider releases for the specified major
|
|
version
|
|
:type major_version: str or None
|
|
|
|
:returns: version number
|
|
|
|
"""
|
|
# Create a connection to the azure org
|
|
organization_url = 'https://dev.azure.com/certbot'
|
|
connection = Connection(base_url=organization_url)
|
|
|
|
# Find the build artifacts
|
|
build_client = connection.clients.get_build_client()
|
|
builds = build_client.get_builds('certbot', definitions='3')
|
|
for build in builds:
|
|
version = build_client.get_build('certbot', build.id).source_branch.split('v')[1]
|
|
if major_version is None or version.split('.')[0] == major_version:
|
|
return version
|
|
raise ValueError('Release not found on Azure Pipelines!')
|
|
|
|
def main(args):
|
|
parsed_args = parse_args(args)
|
|
|
|
css = parsed_args.css
|
|
version = fetch_version_number()
|
|
|
|
# Once the GitHub release has been published, trying to publish it
|
|
# again fails. Publishing the snaps can be done multiple times though
|
|
# so we do that first to make it easier to run the script again later
|
|
# if something goes wrong.
|
|
promote_snaps(ALL_SNAPS, 'beta', version)
|
|
publish_windows(css)
|
|
|
|
if __name__ == "__main__":
|
|
main(sys.argv[1:])
|