mirror of
https://github.com/certbot/certbot.git
synced 2026-01-26 07:41:33 +03:00
6628bc0e9b
random25863.example.org appears in multiple port 80 virtualhosts in the nginx testdata tarball and also is in the nginx-roundtrip-testdata. Certbot doesn't handle these properly, which results in random test failures. This commit ensures that random25863.example.org only appears in a single virtualhost and should ensure that the tests pass consistently.
Eventually there will also be a compatibility test here like the Apache one. Right now, this is data for the roundtrip test (checking that the parser can parse each file and that the reserialized config file it generates is identical to the original). If run in a virtualenv or otherwise so that certbot_nginx can be imported, the roundtrip test can run as python roundtrip.py nginx-roundtrip-testdata It gives exit status 0 for success and 1 if at least one parse or roundtrip failure occurred. The directory nginx-roundtrip-testdata includes some config files that were contributed to our project as well as most of the configs linked from https://www.nginx.com/resources/wiki/start/ Some exceptions that were skipped are https://www.nginx.com/resources/wiki/start/topics/recipes/moinmoin/ https://www.nginx.com/resources/wiki/start/topics/examples/SSL-Offloader/ (not much nginx configuration) https://www.nginx.com/resources/wiki/start/topics/examples/xsendfile/ (likewise) https://www.nginx.com/resources/wiki/start/topics/examples/x-accel/ https://www.nginx.com/resources/wiki/start/topics/examples/fcgiwrap/