mirror of
https://github.com/certbot/certbot.git
synced 2026-01-26 07:41:33 +03:00
* Improve assertions in certbot-apache tests. Replacements inspired by flake8-assertive. * Fix test failures * assertEqual is not for None :D * Pass all tests :)
141 lines
5.6 KiB
Python
141 lines
5.6 KiB
Python
"""Test for certbot_apache._internal.configurator for Gentoo overrides"""
|
|
import unittest
|
|
|
|
try:
|
|
import mock
|
|
except ImportError: # pragma: no cover
|
|
from unittest import mock # type: ignore
|
|
|
|
from certbot import errors
|
|
from certbot.compat import filesystem
|
|
from certbot.compat import os
|
|
from certbot_apache._internal import obj
|
|
from certbot_apache._internal import override_gentoo
|
|
import util
|
|
|
|
|
|
def get_vh_truth(temp_dir, config_name):
|
|
"""Return the ground truth for the specified directory."""
|
|
prefix = os.path.join(
|
|
temp_dir, config_name, "apache2/vhosts.d")
|
|
|
|
aug_pre = "/files" + prefix
|
|
vh_truth = [
|
|
obj.VirtualHost(
|
|
os.path.join(prefix, "gentoo.example.com.conf"),
|
|
os.path.join(aug_pre, "gentoo.example.com.conf/VirtualHost"),
|
|
{obj.Addr.fromstring("*:80")},
|
|
False, True, "gentoo.example.com"),
|
|
obj.VirtualHost(
|
|
os.path.join(prefix, "00_default_vhost.conf"),
|
|
os.path.join(aug_pre, "00_default_vhost.conf/IfDefine/VirtualHost"),
|
|
{obj.Addr.fromstring("*:80")},
|
|
False, True, "localhost"),
|
|
obj.VirtualHost(
|
|
os.path.join(prefix, "00_default_ssl_vhost.conf"),
|
|
os.path.join(aug_pre,
|
|
"00_default_ssl_vhost.conf" +
|
|
"/IfDefine/IfDefine/IfModule/VirtualHost"),
|
|
{obj.Addr.fromstring("_default_:443")},
|
|
True, True, "localhost")
|
|
]
|
|
return vh_truth
|
|
|
|
class MultipleVhostsTestGentoo(util.ApacheTest):
|
|
"""Multiple vhost tests for non-debian distro"""
|
|
|
|
_multiprocess_can_split_ = True
|
|
|
|
def setUp(self): # pylint: disable=arguments-differ
|
|
test_dir = "gentoo_apache/apache"
|
|
config_root = "gentoo_apache/apache/apache2"
|
|
vhost_root = "gentoo_apache/apache/apache2/vhosts.d"
|
|
super().setUp(test_dir=test_dir,
|
|
config_root=config_root,
|
|
vhost_root=vhost_root)
|
|
|
|
# pylint: disable=line-too-long
|
|
with mock.patch("certbot_apache._internal.override_gentoo.GentooParser.update_runtime_variables"):
|
|
self.config = util.get_apache_configurator(
|
|
self.config_path, self.vhost_path, self.config_dir, self.work_dir,
|
|
os_info="gentoo")
|
|
self.vh_truth = get_vh_truth(
|
|
self.temp_dir, "gentoo_apache/apache")
|
|
|
|
def test_get_parser(self):
|
|
self.assertIsInstance(self.config.parser, override_gentoo.GentooParser)
|
|
|
|
def test_get_virtual_hosts(self):
|
|
"""Make sure all vhosts are being properly found."""
|
|
vhs = self.config.get_virtual_hosts()
|
|
self.assertEqual(len(vhs), 3)
|
|
found = 0
|
|
|
|
for vhost in vhs:
|
|
for gentoo_truth in self.vh_truth:
|
|
if vhost == gentoo_truth:
|
|
found += 1
|
|
break
|
|
else:
|
|
raise Exception("Missed: %s" % vhost) # pragma: no cover
|
|
self.assertEqual(found, 3)
|
|
|
|
def test_get_sysconfig_vars(self):
|
|
"""Make sure we read the Gentoo APACHE2_OPTS variable correctly"""
|
|
defines = ['DEFAULT_VHOST', 'INFO',
|
|
'SSL', 'SSL_DEFAULT_VHOST', 'LANGUAGE']
|
|
self.config.parser.apacheconfig_filep = filesystem.realpath(
|
|
os.path.join(self.config.parser.root, "../conf.d/apache2"))
|
|
self.config.parser.variables = {}
|
|
with mock.patch("certbot_apache._internal.override_gentoo.GentooParser.update_modules"):
|
|
self.config.parser.update_runtime_variables()
|
|
for define in defines:
|
|
self.assertIn(define, self.config.parser.variables)
|
|
|
|
@mock.patch("certbot_apache._internal.apache_util.parse_from_subprocess")
|
|
def test_no_binary_configdump(self, mock_subprocess):
|
|
"""Make sure we don't call binary dumps other than modules from Apache
|
|
as this is not supported in Gentoo currently"""
|
|
|
|
with mock.patch("certbot_apache._internal.override_gentoo.GentooParser.update_modules"):
|
|
self.config.parser.update_runtime_variables()
|
|
self.config.parser.reset_modules()
|
|
self.assertIs(mock_subprocess.called, False)
|
|
|
|
self.config.parser.update_runtime_variables()
|
|
self.config.parser.reset_modules()
|
|
self.assertIs(mock_subprocess.called, True)
|
|
|
|
@mock.patch("certbot_apache._internal.apache_util._get_runtime_cfg")
|
|
def test_opportunistic_httpd_runtime_parsing(self, mock_get):
|
|
mod_val = (
|
|
'Loaded Modules:\n'
|
|
' mock_module (static)\n'
|
|
' another_module (static)\n'
|
|
)
|
|
def mock_get_cfg(command):
|
|
"""Mock httpd process stdout"""
|
|
if command == ['apache2ctl', 'modules']:
|
|
return mod_val
|
|
return None # pragma: no cover
|
|
mock_get.side_effect = mock_get_cfg
|
|
self.config.parser.modules = {}
|
|
|
|
with mock.patch("certbot.util.get_os_info") as mock_osi:
|
|
# Make sure we have the have the Gentoo httpd constants
|
|
mock_osi.return_value = ("gentoo", "123")
|
|
self.config.parser.update_runtime_variables()
|
|
|
|
self.assertEqual(mock_get.call_count, 1)
|
|
self.assertEqual(len(self.config.parser.modules), 4)
|
|
self.assertIn("mod_another.c", self.config.parser.modules)
|
|
|
|
@mock.patch("certbot_apache._internal.configurator.util.run_script")
|
|
def test_alt_restart_works(self, mock_run_script):
|
|
mock_run_script.side_effect = [None, errors.SubprocessError, None]
|
|
self.config.restart()
|
|
self.assertEqual(mock_run_script.call_count, 3)
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main() # pragma: no cover
|