mirror of
https://github.com/certbot/certbot.git
synced 2026-01-13 10:22:20 +03:00
e02d641490
These changes allow developers to run tests directly from the host machine using Docker, and to enable ipdb inside the container. docker-compose.yml is upgraded to version 2 format. This means that you need docker-engine version >= 1.10.0 instead of previous requirement of version >= 1.9.1. The reason for this is to be able to use custom Dockerfile (Dockerfile-dev in this case) in build context. ipdb has been added to dev dependencies to be able to be able to debug the code without installing it on every docker run. This is also what we recommend for debugging in the developer documentation, so there really is no reason not to install it with the dev dependencies. setuptools is being upgraded to a newer version to be able to run coverage tests. This was using the older version of setuptools for some reason, and without the upgrade, coverage tests would fail horribly. Upgrading remedies the situation. Few examples: Run unit tests for certbot-apache `docker-compose run --rm --service-ports development bash -c 'cd src;nosetests -v certbot-apache'` Run coverage tests `docker-compose run --rm --service-ports development bash -c 'cd src;./tox.cover.sh'` Run linter `docker-compose run --rm --service-ports development bash -c 'cd src;tox -e lint'`
70 lines
2.8 KiB
Plaintext
70 lines
2.8 KiB
Plaintext
# This Dockerfile builds an image for development.
|
|
FROM ubuntu:trusty
|
|
MAINTAINER Jakub Warmuz <jakub@warmuz.org>
|
|
MAINTAINER William Budington <bill@eff.org>
|
|
MAINTAINER Yan <yan@eff.org>
|
|
|
|
# Note: this only exposes the port to other docker containers. You
|
|
# still have to bind to 443@host at runtime, as per the ACME spec.
|
|
EXPOSE 443
|
|
|
|
# TODO: make sure --config-dir and --work-dir cannot be changed
|
|
# through the CLI (certbot-docker wrapper that uses standalone
|
|
# authenticator and text mode only?)
|
|
VOLUME /etc/letsencrypt /var/lib/letsencrypt
|
|
|
|
WORKDIR /opt/certbot
|
|
|
|
# no need to mkdir anything:
|
|
# https://docs.docker.com/reference/builder/#copy
|
|
# If <dest> doesn't exist, it is created along with all missing
|
|
# directories in its path.
|
|
|
|
# TODO: Install non-default Python versions for tox.
|
|
# TODO: Install Apache/Nginx for plugin development.
|
|
COPY letsencrypt-auto-source/letsencrypt-auto /opt/certbot/src/letsencrypt-auto-source/letsencrypt-auto
|
|
RUN /opt/certbot/src/letsencrypt-auto-source/letsencrypt-auto --os-packages-only && \
|
|
apt-get clean && \
|
|
rm -rf /var/lib/apt/lists/* \
|
|
/tmp/* \
|
|
/var/tmp/*
|
|
|
|
# the above is not likely to change, so by putting it further up the
|
|
# Dockerfile we make sure we cache as much as possible
|
|
|
|
COPY setup.py README.rst CHANGES.rst MANIFEST.in linter_plugin.py tox.cover.sh tox.ini .pylintrc /opt/certbot/src/
|
|
|
|
# all above files are necessary for setup.py, however, package source
|
|
# code directory has to be copied separately to a subdirectory...
|
|
# https://docs.docker.com/reference/builder/#copy: "If <src> is a
|
|
# directory, the entire contents of the directory are copied,
|
|
# including filesystem metadata. Note: The directory itself is not
|
|
# copied, just its contents." Order again matters, three files are far
|
|
# more likely to be cached than the whole project directory
|
|
|
|
COPY certbot /opt/certbot/src/certbot/
|
|
COPY acme /opt/certbot/src/acme/
|
|
COPY certbot-apache /opt/certbot/src/certbot-apache/
|
|
COPY certbot-nginx /opt/certbot/src/certbot-nginx/
|
|
COPY letshelp-certbot /opt/certbot/src/letshelp-certbot/
|
|
COPY certbot-compatibility-test /opt/certbot/src/certbot-compatibility-test/
|
|
COPY tests /opt/certbot/src/tests/
|
|
|
|
RUN virtualenv --no-site-packages -p python2 /opt/certbot/venv && \
|
|
/opt/certbot/venv/bin/pip install \
|
|
-e /opt/certbot/src/acme \
|
|
-e /opt/certbot/src \
|
|
-e /opt/certbot/src/certbot-apache \
|
|
-e /opt/certbot/src/certbot-nginx \
|
|
-e /opt/certbot/src/letshelp-certbot \
|
|
-e /opt/certbot/src/certbot-compatibility-test \
|
|
-e /opt/certbot/src[dev,docs] && \
|
|
/opt/certbot/venv/bin/pip install -U setuptools
|
|
|
|
# install in editable mode (-e) to save space: it's not possible to
|
|
# "rm -rf /opt/certbot/src" (it's stays in the underlaying image);
|
|
# this might also help in debugging: you can "docker run --entrypoint
|
|
# bash" and investigate, apply patches, etc.
|
|
|
|
ENV PATH /opt/certbot/venv/bin:$PATH
|