Peter Eckersley
f5cf58f42e
with .. open .. as # definitely nicer
2015-12-22 15:42:53 -08:00
Peter Eckersley
e41339cda8
Keep lint happy
...
(But what about py3?)
2015-12-21 20:01:28 -08:00
Peter Eckersley
aa6bf73d4a
Only test permission failures if we're not root
...
or, more generally, if we're on a system where permissions are being enforced
Closes : #1979
2015-12-21 19:58:07 -08:00
Peter Eckersley
0751244597
Merge pull request #1875 from letsencrypt/webroot-permissions
...
Webroot permissions
2015-12-12 00:32:16 -08:00
Brad Warren
1a7dd76288
Added test coverage
2015-12-11 19:31:50 -08:00
Brad Warren
d45865a601
Cleanup
2015-12-11 19:14:23 -08:00
Brad Warren
2d52559466
Cleanup comment
2015-12-11 18:12:46 -08:00
Joe Ranweiler
f4d499dbad
Make help message indicate derived challenge preference
2015-12-11 18:07:25 -08:00
Joe Ranweiler
2f904a41e0
Derive preference order from supported_challenges order
2015-12-11 18:06:11 -08:00
Brad Warren
74927613e9
Fixed lint issues
2015-12-11 18:03:52 -08:00
Joe Ranweiler
c66c6bae1d
Make supported_challenges return a list, not set
2015-12-11 18:00:33 -08:00
Luca Beltrame
2b942d97b2
Address review comments
...
- move the umask call before the try/except block
- move comment in _prepare_single to the umask call
Simplify the code comments, too.
Tests still pass.
2015-12-07 11:17:29 +01:00
Luca Beltrame
edf3a4ed73
Make webroot usable also when running as non-root (GH #1795 )
...
Thanks to @aburch's suggestions, the logic has been changed:
- Set umask before creating folders and files
- Leverage os.makedirs' mode option in conjunction with umask
The program still tries to change owner / group, but in case of errors
it continues gracefully.
Tests have been updated, and they pass.
2015-12-07 10:49:24 +01:00
Joe Ranweiler
dbf181ebac
Respect config when stating challenge preferences
2015-12-03 00:28:12 -08:00
Joe Ranweiler
8cf47e3aba
Add tests to check that configuration is used
...
The existing tests use the case in which the (configured) supported
challenges are equal to the defaults, and in the same (now-fixed) order.
These additional tests check that, if we have configured a subset of the
supported challenges, then we actually _use_ that configuration.
2015-12-03 00:13:09 -08:00
Joe Ranweiler
d5511971aa
Update plugin help string
2015-12-02 22:50:32 -08:00
Joe Ranweiler
fa55871598
Remove dead import
2015-12-02 22:14:32 -08:00
Joe Ranweiler
a0142dbe44
Don't randomize challenge preference
2015-12-02 22:13:05 -08:00
Joe Ranweiler
144a678473
Encode challenge preference order in constant
2015-12-02 22:12:18 -08:00
Joe Ranweiler
5054a3dd79
Fix typo in test name
2015-12-02 21:57:31 -08:00
Joe Ranweiler
55d4365a46
Expect a fixed standalone challenge preference
2015-12-02 21:30:05 -08:00
Peter Eckersley
02d93e995a
lint
2015-12-01 19:24:14 -08:00
Peter Eckersley
a191daf3ee
Merge pull request #1597 from lbeltrame/fix-webroot-permissions
...
Fix webroot permissions [mergeable, but enhancements also requested]
2015-12-01 19:07:06 -08:00
Peter Eckersley
f4dd660403
Oops!
...
- Finish a partial commit, providing what are perhaps excessively detailed and
mystical errors in improbable cases.
2015-12-01 16:50:39 -08:00
Peter Eckersley
06e273413b
Fix nits and address review comments
2015-12-01 16:33:35 -08:00
Peter Eckersley
6c9ddf34e6
Merge remote-tracking branch 'origin/master' into webroot
2015-11-30 20:57:27 -08:00
Peter Eckersley
328f8cdc5b
Document --webroot-path
2015-11-30 18:24:40 -08:00
bmw
8cf63c493f
Merge pull request #1568 from erikrose/kill-dvsni
...
Remove remaining "DVSNI" wording, changing it to reference TLS-SNI-01, which it changed into.
2015-11-25 15:30:02 -05:00
Erik Rose
e75dc96559
Stop calling things that don't implement IAuthenticator authenticators.
2015-11-25 12:44:17 -05:00
Luca Beltrame
2a5f539d9a
Add tests for testing gid and uid with the webroot plugin
...
They pass.
2015-11-25 14:26:51 +01:00
Luca Beltrame
a58c939c8d
Change ownership of the validation paths as well
...
Match them with the parent directory they're in.
2015-11-25 14:26:00 +01:00
Luca Beltrame
c7c1808ad1
Add unit tests for webroot permissions handling
...
Tested, pass.
2015-11-24 10:15:18 +01:00
Luca Beltrame
a71c3ed90c
Fix issues from review
...
- Put chmod argument to os.chmod (oops)
- Add permissions adjustments for challenge files, too
2015-11-24 10:15:18 +01:00
Patrick Figel
c175ff955e
Remove Content-Type checks from http-01
...
Content-Type type restrictions were removed in ACME, see
69ac2baadefixes #1595
2015-11-24 09:54:33 +01:00
bmw
72d91c3ccd
Merge pull request #1534 from TheNavigat/allow-public-ip-logging
...
Allow public IP logging
2015-11-23 13:26:11 -05:00
Luca Beltrame
768c7cd9c0
Fix webroot permissions
...
Take them from the parent directory where the webroot is.Should fix issue #1389
2015-11-22 15:16:50 +01:00
Peter Eckersley
a3b0588cea
lintmonster
2015-11-21 11:50:13 -08:00
Peter Eckersley
544fe8d708
Fix webroot tests
2015-11-21 11:23:53 -08:00
Peter Eckersley
f48ef6ded9
lint
2015-11-21 10:59:15 -08:00
Peter Eckersley
f2f9d33e03
Update _path_for_achall
...
Borrowing from @grubberr's changes at:
https://github.com/letsencrypt/letsencrypt/pull/1284/files#diff-522ab130649a0ce14df40114d4ccd0b5L111
2015-11-21 10:59:15 -08:00
Peter Eckersley
ffe6226edc
Switch webroot.prepare() to use config.webroot_map
2015-11-21 10:59:15 -08:00
Peter Eckersley
e1f0fcca8f
Move --webroot-path processing into cli.py
...
Since it is now interdependent with --domains
(This is much more elegant than trying to APIify the interaction)
2015-11-21 10:59:15 -08:00
Peter Eckersley
19f348b416
First implementation of -w for multi-webroot specification
...
* Will need tests and cleanup
2015-11-21 10:59:15 -08:00
Brad Warren
6b23fe160e
Added tests
2015-11-20 18:34:35 -08:00
Brad Warren
368f208b7f
Log not fail
2015-11-20 18:26:44 -08:00
Erik Rose
9205b9c987
Remove remaining "DVSNI" wording, changing it to reference TLS-SNI-01, which it changed into. Close #1417 .
...
Also make _get_addrs() private, since it's called only internally.
2015-11-19 13:23:07 -05:00
Nav
569962b40d
Fixing manual authenticator tests
2015-11-17 11:50:32 +02:00
Nav
9fd1b1f38a
Fixes #1176
2015-11-17 11:06:12 +02:00
Peter Eckersley
ca05b35a24
Merge pull request #1412 from kuba/pep8
...
pep8 love
2015-11-12 00:29:15 -08:00
Jakub Warmuz
5ee17f698e
Fix more pep8
2015-11-07 19:37:00 +00:00
