Peter Eckersley
dcf8ea4e97
Logic for setting configurators assumed they were really being set
...
(They might not be)
2015-10-16 17:38:17 -07:00
Peter Eckersley
3d6ecc114b
lintmonster
2015-10-16 10:41:05 -07:00
Peter Eckersley
9bde3b7084
Support for --apache and --nginx now working.
...
- Along with much better error messages for misconfigured plugins
2015-10-16 10:34:29 -07:00
Peter Eckersley
78be30d457
Basic support for --apache and --nginx
...
- Also begin to clean up the code that integrates --configurator,
--installer, and --authenticator inputs.
2015-10-13 14:38:31 -07:00
Jakub Warmuz
73ee63779c
Remove --no-simple-http-tls
2015-10-07 06:23:28 +00:00
Jakub Warmuz
0d89fa6d88
Remove SimpleHTTP TLS from Manual Plugin.
2015-10-07 06:21:49 +00:00
bmw
f81174d43d
Merge pull request #722 from kuba/mock-2.6
...
Revert "Revert PR #708."
2015-10-06 11:05:32 -07:00
bmw
0aaf26bdda
Merge pull request #878 from letsencrypt/automation_is_enabled
...
Ensures renewal settings are reported correctly
2015-10-05 14:54:02 -07:00
bmw
e985c54b9b
Merge pull request #898 from ArchimedesPi/pep8
...
Fix some pep8 warnings
2015-10-05 13:53:02 -07:00
bmw
505ebfaa45
Merge pull request #891 from ArchimedesPi/remove_crypto_util_cruft
...
crypto_util: Remove cruft
2015-10-05 13:00:52 -07:00
Jakub Warmuz
c3e28fa909
Merge remote-tracking branch 'github/letsencrypt/master' into mock-2.6
2015-10-05 19:31:05 +00:00
Brad Warren
7a49e2bcb3
Merge branch 'master' into automation_is_enabled
2015-10-05 12:09:40 -07:00
Brad Warren
a86ea53a79
Added unit tests
2015-10-05 12:09:35 -07:00
Peter Eckersley
22d756992b
Merge pull request #894 from ArchimedesPi/improve-test-coverage-crypto-util
...
crypto_util: Refactor, improve test coverage [WIP]
2015-10-05 12:05:14 -07:00
Liam Marshall
d5ebc38b33
Fix pep8 warnings (down to only one now!)
2015-10-04 20:39:19 -05:00
Liam Marshall
917a6d6373
Make lint happy, remove unused variables from crypto_util_test
2015-10-04 15:56:40 -05:00
Liam Marshall
9c8f09ec43
Test that loading an invalid cert throws an error
2015-10-04 15:49:56 -05:00
Liam Marshall
b3bd71b424
Use previously-returned file_type in assertion
2015-10-04 15:43:51 -05:00
Liam Marshall
7b50f5d9bf
Make pep8 happy
2015-10-04 15:42:05 -05:00
Liam Marshall
aa15fae11d
crypto_util: merge _pyopenssl_load into pyopenssl_load_certificate
2015-10-04 15:39:29 -05:00
Liam Marshall
7b2d40ce55
crypto_util: test pyopenssl_load_certificate(...)
2015-10-04 15:34:57 -05:00
Liam Marshall
032f3e8f64
crypto_util: test _pyopenssl_load
2015-10-04 15:00:57 -05:00
Liam Marshall
884d8e9905
crypto_util: Remove unused import
2015-10-04 11:29:21 -05:00
Liam Marshall
6994dad59b
crypto_util: Remove asn1_generalizedtime_to_dt(...)
2015-10-04 11:17:07 -05:00
Liam Marshall
32da607ae5
crypto_util: Remove asn1_generalizedtime_to_dt(...)
...
Not used by any other code AFAIK (ack'd entire codebase).
2015-10-04 10:39:38 -05:00
Jakub Warmuz
4ef7a6e63f
Merge remote-tracking branch 'github/letsencrypt/master' into release
2015-10-04 10:08:38 +00:00
Jakub Warmuz
5d4e1b68cd
autospec=False for socket.socket (quick-fixes: #779 ).
...
Also, https://github.com/testing-cabal/mock/issues/323
2015-10-04 08:57:53 +00:00
Brad Warren
8e45ecd975
Merge branch 'master' into sysexit_error
2015-10-01 15:40:08 -07:00
Brad Warren
d7a16ecfcb
Added tests and documentation
2015-10-01 15:39:55 -07:00
Brad Warren
59348ad30c
Made methods private and updated tests
2015-10-01 13:33:22 -07:00
Brad Warren
c976c0abdf
Removed duplicated code
2015-10-01 13:03:23 -07:00
Brad Warren
6bde83c983
Fixed indentation in storage.py
2015-10-01 11:53:11 -07:00
Peter Eckersley
43cb36807a
Also test top level help
2015-09-30 17:00:09 -07:00
Peter Eckersley
11ca1108c2
Test cases for command line help
2015-09-30 16:53:08 -07:00
Peter Eckersley
2406fc0486
Go back to VERBS as a list
...
The dictionary was destroying the ordering, which was important.
2015-09-30 16:07:16 -07:00
Peter Eckersley
d85f42d71f
Plugins don't need to be in HELP_TOPICS
...
They're already added as topics automatically, though they do need to be in
the hand-written top level help.
2015-09-30 15:29:29 -07:00
Brad Warren
bb167743f3
Don't call_registered() on SystemExit
2015-09-30 13:00:10 -07:00
Peter Eckersley
2d578468bd
Use a verb -> function table instead of eval()
...
- plugins_cmd() not plugins() broke the more minimalist eval() approach
- more wrangling was required to mock out calls via the VERBS table
2015-09-30 12:32:44 -07:00
Peter Eckersley
2a3a111d62
Disable pylint invalid-name
...
It's clearly making our code harder to read and write
2015-09-30 12:10:16 -07:00
Peter Eckersley
1e3c92c714
Cleanup the verb -> subparser mapping
2015-09-30 11:49:46 -07:00
Peter Eckersley
627fca37b4
We didn't actually need to define --help as a verb
2015-09-29 18:55:59 -07:00
Peter Eckersley
18dacc528d
Preserve all argparse parameters
...
Try to restore all variants that applied to the different subcomannds
2015-09-29 18:55:59 -07:00
Peter Eckersley
6b6bc03882
--cert-path was required for install and revoke
...
Oops
2015-09-29 17:14:40 -07:00
Peter Eckersley
2297349b95
lintian
2015-09-29 16:56:36 -07:00
Peter Eckersley
4437ec5586
Merge remote-tracking branch 'origin/master' into subargs
2015-09-29 14:49:32 -07:00
Peter Eckersley
05d439a339
Update cli tests
...
We don't expect to error out if called with no args
2015-09-29 14:48:40 -07:00
Peter Eckersley
a0af023b14
--key-path is mandatory for install, optional for revoke
2015-09-29 14:48:26 -07:00
Peter Eckersley
2e0fd36c28
Improve flag and help processing
...
* letsencrypt --help $SUBCOMMAND now works.
Fixes #787 #819
* subcommand arguments are now actually argument groups, so that all flags
can be placed before or after subcommand verbs as the user wishes
Fixes : #820
A limitation:
* args like --cert-path were previously present for multiple verbs
(auth/install/revoke) with separate docs; they are now in the "paths"
topic. That's fine, though it would be good to *also* list them when the
user types letsencrypt --help install.
2015-09-29 21:01:02 +00:00
Brad Warren
312057b1b8
changes += kuba_feedback
2015-09-29 12:54:52 -07:00
Brad Warren
ed7977fb03
Added cli tests
2015-09-28 18:45:12 -07:00
