1
0
mirror of https://github.com/certbot/certbot.git synced 2026-01-23 07:20:55 +03:00
Commit Graph

92 Commits

Author SHA1 Message Date
Liam Marshall
ca6a77bb1d Fix tests
Remove debugging print from tests

Fix lint warnings
2015-11-18 21:38:56 -06:00
Liam Marshall
b19c9d858c Fix a few nits, coverage 2015-11-18 21:24:43 -06:00
Liam Marshall
e5e7cef6d6 Fix conditional for fullchain_path edge cases 2015-11-18 19:22:14 -06:00
Liam Marshall
76320c2d37 Test vhost cleaning 2015-11-15 23:09:44 -06:00
Liam Marshall
62f19496da Rewrite vhost cleaning logic 2015-11-15 23:09:35 -06:00
Liam Marshall
e6113698f2 Test that no fullchain throws an error 2015-11-14 14:28:17 -06:00
Liam Marshall
a1e6db2144 Fix logic in which the --fullchain error would never be hit 2015-11-14 14:27:38 -06:00
Liam Marshall
691abdc377 Fix for py26 (it doesn't have set literals) 2015-11-14 12:00:08 -06:00
Liam Marshall
425bb98bed Fix lint warnings 2015-11-14 11:44:03 -06:00
Liam Marshall
361b67276e Rewrite certificate install logic
Tests are being written
2015-11-14 11:43:54 -06:00
Liam Marshall
9bf1b99b5b Remove existing SSL directives for SSL vhosts 2015-11-13 17:16:50 -06:00
Liam Marshall
16659b5433 Add minus option to _remove_existing_ssl_directives()
Add test case as well.
2015-11-13 15:59:16 -06:00
Liam Marshall
0af0beaeb7 Remove useless SSL removal on non-SSL vhosts 2015-11-12 22:27:05 -06:00
Liam Marshall
108757e332 Fall back to old cert method if fullchain isn't provided 2015-11-12 17:45:33 -06:00
Liam Marshall
211c2bb33d Remove SSLCACertificatePath from removed directives
SSLCACertificatePath is sometimes important to preserve.
2015-11-10 19:41:30 -06:00
Liam Marshall
1f6ef1f4b1 Add tests for existing cert removal and newcert directives 2015-11-10 16:04:23 -06:00
Liam Marshall
30c44ef1e2 Fix lint errors 2015-11-09 22:13:36 -06:00
Liam Marshall
e63fa279a4 Reintroduce cert_key, remove bad logging 2015-11-09 22:13:36 -06:00
Liam Marshall
b26c138938 Wire in everything, remove cert_key
Add debug. Will be removed.

Logging
2015-11-09 22:13:36 -06:00
Liam Marshall
1d2ba931b3 Improve the implementation of the suggestion
Write the code to set directives

Fix logging in _remove_existing_ssl_directives

Fix logging statement
2015-11-09 22:13:25 -06:00
Liam Marshall
18da7dfce2 Implement @pde's suggestions for Apache
From this IRC log:
2015-11-02 16:31:29	@pdeee	for >= 2.4.8:
2015-11-02 16:32:23	@pdeee	add new SSLCertificateFile pointing to fullchain.pem
2015-11-02 16:33:10	@pdeee	remove all preexisting SSLCertificateFile, SSLCertificateChainFile, SSLCACertificatePath, and possibly other fields subject to careful research :)
2015-11-02 16:33:21	@pdeee	for < 2.4.8:
2015-11-02 16:34:03	@pdeee	add SSLCertificateFile pointing to cert.pem
2015-11-02 16:34:42	@pdeee	and SSLCertificateChainFile pointing to chain.pem
2015-11-02 16:34:50	xamnesiax	gotcha
2015-11-02 16:34:55	@pdeee	remove all preexisting/conflicting entries
2015-11-02 16:35:19	xamnesiax	Am I correct to assume that this can all be done from deploy_certs in the apache configurator?
2015-11-02 16:36:32	xamnesiax	deploy_cert *
2015-11-02 16:36:48	@pdeee	I think so
2015-11-02 16:36:59	@pdeee	again, jdkasten may wish to say more

Pull strings out for find_dir

A bit of logging

Add version logging

Logging, temporarily remove one branch

of the conditional for testing

Fix bad directive stringgrabbing code

Fix directive removal logic

Grab string from tree to be removed
2015-11-09 22:12:39 -06:00
Noah Swartz
5fd4ed9d9d added documentation explaining why we're loading lens 2015-11-04 19:43:11 -08:00
Noah Swartz
af5ab05a58 Revert "switched the httpd.aug to the version from 1.2"
This reverts commit 60fce0b22e.
2015-11-04 19:34:24 -08:00
Jakub Warmuz
f5053ba8af constants.AUGEAS_LENS_DIR 2015-11-04 20:12:39 +00:00
Jakub Warmuz
ac137fc00a Merge remote-tracking branch 'github/letsencrypt/master' into test-embed-lens 2015-11-04 19:38:43 +00:00
Noah Swartz
60fce0b22e switched the httpd.aug to the version from 1.2 2015-11-03 11:08:10 -08:00
Noah Swartz
c0048d7480 load augeas httpd lens from inside of lets encrypt 2015-11-02 16:22:58 -08:00
Jakub Warmuz
063544817b Kill simplehttp apache/nginx 2015-11-01 11:01:22 +00:00
Noah Swartz
fbd09ddbf6 added interesticial saves to apache changes which fixed bug when multiple vhosts were specified 2015-10-30 13:24:55 -07:00
Noah Swartz
05be568e9e added todo notes 2015-10-29 15:18:48 -07:00
David Kreitschmann
39c83d17d7 Add -t to apache2ctl -D DUMP_RUN_CFG
Calling apache2ctl -D DUMP_RUN_CFG on Debian Wheezy (Apache 2.2) will
open a socket which breaks standalone auth. letsencrypt still won’t
work with apache 2.2 because it only returns „Syntax OK“.
Apache 2.4 works the same with or without -t.
2015-10-29 10:06:32 +01:00
Sharif Nassar
424f4f08b9 Make ./pep8.travis.sh run cleanly
98% whitespace.
2015-10-20 22:24:58 -07:00
James Kasten
ccd9c54a6f Merge pull request #949 from kuba/bugs/838
Fix tests under dev release packaging
2015-10-13 14:38:17 -04:00
Jacob Hoffman-Andrews
f0cfd69cdc Respond to review feedback. 2015-10-11 11:28:39 -07:00
Jacob Hoffman-Andrews
dd8c6d6548 Nginx improvements
Add a server_names_hash_bucket_size directive during challenges to fix an nginx
crash on restart (Fixes #922).

Use fullchain instead of chain (Fixes #610).

Implement OCSP stapling (Fixes #937, Fixes #931).

Hide Boulder output in integration tests to make them more readable.
2015-10-11 10:20:08 -07:00
Jakub Warmuz
5edd809161 ApacheConfigurator.is_enabled using filecmp (fixes #838). 2015-10-11 10:51:24 +00:00
Brad Warren
9cf2ea8a57 Report Apache correctly when uninstalled 2015-09-30 17:16:27 -07:00
Jakub Warmuz
5d8e9a3d68 Fix various doc generation issues 2015-09-27 21:07:40 +00:00
James Kasten
d4d71a73a5 Remove trailing whitespace 2015-09-22 09:16:49 -07:00
James Kasten
e922a82277 letsencrypt-apache/ 2015-09-22 09:06:53 -07:00
James Kasten
202b21f260 Remove extra # 2015-09-22 08:58:02 -07:00
James Kasten
19d65c3e2f Add variable quote parsing 2015-09-22 08:56:26 -07:00
James Kasten
6e4faac9c0 Allow single/double quotes around Include dirs 2015-09-22 08:15:11 -07:00
James Kasten
b5c8da2188 remove space 2015-09-17 02:20:15 -07:00
James Kasten
f2cee505f5 fix 781 2015-09-17 02:14:53 -07:00
Jakub Warmuz
33c2aed021 Merge remote-tracking branch 'github/letsencrypt/master' into lint 2015-09-11 07:15:10 +00:00
James Kasten
4fb27e0350 fix documentation link 2015-09-10 18:48:44 -07:00
James Kasten
7a66bfef28 method to func, thanks pylint 2015-09-10 16:49:50 -07:00
James Kasten
9c47b1061c Search for correct module names in dependency list 2015-09-10 16:34:20 -07:00
James Kasten
b2ef041785 Don't log notes if save is temporary 2015-09-10 15:57:27 -07:00