1
0
mirror of https://github.com/certbot/certbot.git synced 2026-01-23 07:20:55 +03:00
Commit Graph

166 Commits

Author SHA1 Message Date
bmw
c8999f86a1 Merge pull request #1200 from kuba/bugs/1085
Remove serve_forever2/shutdown2 (reduces probability of #1085).
2015-10-29 18:20:36 -07:00
Brad Warren
4b407b9599 Merge branch 'typos' 2015-10-29 17:03:05 -07:00
Jakub Warmuz
4cc0610679 Remove serve_forever2/shutdown2 (reduces probability of #1085).
I'm not even sure why `serve_forever2` and `shutdown2` were introduced
in the first place... It probably follows from my misconception about
the SocketServer module. After having studied the module again, I come
to the conclusion that we can get rid of my crap, simultanously
reducing probability of #1085 (hopefully down to 0)!

`server_forever` is used throughout tests instead of `handle_request`,
because `shutdown`, following docs, "must be called while
serve_forever() is running in another thread, or it will deadlock",
and our `probe_sni` HTTP request is already enough to kill single
`handle_request`.

We don't need to use any busy waiting block or `sleep` between serve
and shutdown; studying CPython source code leads to the conclusion
that the following construction is non-blocking:

```python
import threading, SocketServer
s = SocketServer.TCPServer(("", 0), None)
t = threading.Thread(target=s.shutdown)
t.start()
s.serve_forever()  # returns immediately
t.join()  # returns immediately
```
2015-10-29 21:02:21 +00:00
Brad Warren
de30a28555 Another shot at a description 2015-10-29 13:20:52 -07:00
Brad Warren
faa61da2a6 manual_description += kuba_feedback 2015-10-29 10:46:39 -07:00
Brad Warren
e9661c9634 Fixed tests 2015-10-28 19:57:56 -07:00
Brad Warren
df2ba1ba46 standalone_description += pde_feedback 2015-10-28 19:13:41 -07:00
bmw
4f64a6bd81 Merge pull request #1079 from SwartzCr/issue_611
Fixed nits with plugin choice
2015-10-28 16:43:28 -07:00
Noah Swartz
989c4d9514 fixed tests to match updated description string 2015-10-28 15:37:43 -07:00
Noah Swartz
09f9b6a348 added back docstring to manual 2015-10-28 11:16:23 -07:00
Noah Swartz
358c7b11f4 changed Standalone description 2015-10-28 11:05:11 -07:00
Noah Swartz
e404961a76 took into account bmw's suggestions 2015-10-28 10:49:05 -07:00
Jakub Warmuz
5d11691de7 Standalone verifies ports for suported challenges only (fixes #1149). 2015-10-27 22:19:21 +00:00
Scott Merrill
1d13938dbf Correct typo and whitespace issues
* s/privilidged/privileged/
* s/a HTTP/an HTTP/
* Add whitespace at the end of the lines to improve user experience

The lack of trailing whitespace on these entries causes Debian's debconf
interface to join the last word of a line with the first word of the
next line, with no space in between.
2015-10-26 19:50:37 -04:00
Noah Swartz
788cb5fc99 moved info back to docstrings 2015-10-26 13:24:42 -07:00
Liam Marshall
a90013bc2d Make linter happy 2015-10-25 16:43:03 -05:00
Liam Marshall
3f22e0d6f2 test_disagree_with_ip_logging: make it fail nicely 2015-10-25 16:32:56 -05:00
Liam Marshall
0a5303ccf0 test_disagree_with_ip_logging: move, remove spurious @patches 2015-10-25 16:15:10 -05:00
Liam Marshall
88cc70b5a5 Oops, can't use the form of assertRaises on 2.6 2015-10-25 15:46:21 -05:00
Liam Marshall
17bd379017 Clean up tests 2015-10-25 15:37:23 -05:00
Liam Marshall
7e94876f73 Add a test for disagreeing with IP logging 2015-10-25 15:04:26 -05:00
Liam Marshall
a21e149f74 Need to *call* mock_interaction as a function 2015-10-25 14:54:39 -05:00
Liam Marshall
a88f9cdc37 Switch from Error to PluginError 2015-10-25 14:31:30 -05:00
Liam Marshall
a45c4d157a Oops, copy-pasted the patch 2015-10-24 23:27:39 -05:00
Liam Marshall
2d295bce9d Better error message 2015-10-24 22:17:16 -05:00
Liam Marshall
aa0c7d9932 manual_test: mock yesno interaction 2015-10-24 22:03:30 -05:00
Liam Marshall
4adc6d3269 Make pep8 happy 2015-10-24 21:50:27 -05:00
Liam Marshall
a966bc0797 letsencrypt.plugins.manual: Add disclaimer about IP logging 2015-10-24 21:27:49 -05:00
Peter Eckersley
195f36e4e1 plugin_ep.problem unittests
and some misc style things
2015-10-24 14:09:34 -07:00
Peter Eckersley
a567c0578f Pass plugin errors back out to the user.
Closes: #971
2015-10-23 17:17:23 -07:00
Noah Swartz
46ac0169b5 fixed unit test testing standalone desc 2015-10-22 17:44:57 -07:00
Noah Swartz
dd1df820ad hid manual option 2015-10-22 16:09:47 -07:00
Noah Swartz
a385086e2e Fixed nits with plugin choice 2015-10-21 18:02:26 -07:00
Sharif Nassar
39a44b97ed Jedi mind trick on coverage tool 2015-10-21 00:10:47 -07:00
Sharif Nassar
0e18395a1b 100% coverage is the goal, so add a test 2015-10-21 00:10:36 -07:00
Jakub Warmuz
e52922b11e Fix getsockname usage with IPv6 2015-10-20 20:44:18 +00:00
Jakub Warmuz
11495c5820 Better logging for start/stop acme.standalone servers. 2015-10-20 20:16:12 +00:00
Brad Warren
98c74ddd14 Removed no_simple_http_tls 2015-10-19 12:26:59 -07:00
bmw
6534744832 Merge pull request #1005 from kuba/pep8
pep8 love
2015-10-16 17:45:45 -07:00
Brad Warren
69711e432f Merge branch 'simplefs' 2015-10-16 17:37:43 -07:00
Jakub Warmuz
5c1858627b pep8 love 2015-10-16 22:25:20 +00:00
Jakub Warmuz
ec24641511 standalone2: run(): tls -> challenge_type. 2015-10-15 20:31:22 +00:00
Jakub Warmuz
6f44bcf117 standalone2: move alread_listening to perform 2015-10-15 18:01:14 +00:00
Jakub Warmuz
244a020b0a Merge remote-tracking branch 'github/letsencrypt/master' into standalone2 2015-10-14 17:26:35 +00:00
bmw
5ca70e19a7 Merge pull request #950 from letsencrypt/jsha/nginx-improvements
Nginx improvements
2015-10-12 16:41:52 -07:00
Jakub Warmuz
73ae361559 Merge remote-tracking branch 'github/letsencrypt/master' into standalone2 2015-10-12 19:36:46 +00:00
Brandon Kreisel
52f7a64b84 lint newline 2015-10-11 17:56:30 -04:00
Jacob Hoffman-Andrews
06c85d6b5a Fix line-wrapped function indents. 2015-10-11 11:30:11 -07:00
Jacob Hoffman-Andrews
dd8c6d6548 Nginx improvements
Add a server_names_hash_bucket_size directive during challenges to fix an nginx
crash on restart (Fixes #922).

Use fullchain instead of chain (Fixes #610).

Implement OCSP stapling (Fixes #937, Fixes #931).

Hide Boulder output in integration tests to make them more readable.
2015-10-11 10:20:08 -07:00
Jakub Warmuz
304414a214 Remove SimpleHTTP TLS from acme. 2015-10-08 21:10:12 +00:00