1
0
mirror of https://github.com/certbot/certbot.git synced 2025-08-09 15:02:48 +03:00

Fail-fast in test/cover/lint scripts (#6487)

After #6485 and #6435, it appears that there is no good reason to not fail fast when test, cover or linting scripts are executed.

This PR ensures to fail fast by invoking commands throught subprocess.check_call instead of subprocess.call, and by removing the handling of non-zero exit code at the end of theses scripts.

As now coverage on Windows is executed with thresholds, I added specific thresholds for this platform. Because some portions of code that are done for Unix platform will not be executed on Windows.

Note that coverage reports from Travis and AppVeyor are accumulated on Codecov. So if a file is covered up to 50 % on Linux, and all other parts are covered on Windows, then coverage is 100 % for Codecov.

Note: that PR also fixes the ability of coverage tests to fail if thresholds are exceeded.

* Use check_call to fail fast in all scripts related to tests/lint/coverage/deploy

* Make specific coverage threshold for windows
This commit is contained in:
Adrien Ferrand
2018-11-14 22:57:40 +01:00
committed by Brad Warren
parent ad885afdb8
commit b3d2ac5161
8 changed files with 51 additions and 66 deletions

View File

@@ -53,7 +53,7 @@ def main():
venv_args = get_venv_args()
return _venv_common.main('venv', venv_args, REQUIREMENTS)
_venv_common.main('venv', venv_args, REQUIREMENTS)
if __name__ == '__main__':
sys.exit(main())
main()