crypt/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2025-08-08 04:02:10 +03:00
Code Activity

Always "pipstrap" when running pip_install.py (#9658)

Browse Source 
Fixes https://github.com/certbot/certbot/issues/7921.

In all cases when we run `pip_install.py`, we first run `pipstrap.py`. This PR combines these two steps for convenience and to make always doing that less error prone. This will also help me with some of the `tox.ini` refactoring I'm planning to do.

I ran the full test suite on everything and tested the release script changes locally.

This change shouldn't have any effect on cryptography's setup because they install `certbot[test]` which depends on pip, setuptools, and wheel.

* always pipstrap

* use pip_install.py during releases
This commit is contained in:
Brad Warren
2023-04-05 16:43:26 -07:00
committed by GitHub
parent 45327d00c4
commit a78073812c
9 changed files with 39 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools/venv.py
View File

@@ -197,7 +197,6 @@ def install_packages(venv_name, pip_args):
"""
# Using the python executable from venv, we ensure to execute following commands in this venv.
py_venv = get_venv_python_path(venv_name)
subprocess_with_print([py_venv, os.path.abspath('tools/pipstrap.py')])
command = [py_venv, os.path.abspath('tools/pip_install.py')]
command.extend(pip_args)
subprocess_with_print(command)