crypt/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2025-08-08 04:02:10 +03:00
Code Activity

Always "pipstrap" when running pip_install.py (#9658)

Browse Source 
Fixes https://github.com/certbot/certbot/issues/7921.

In all cases when we run `pip_install.py`, we first run `pipstrap.py`. This PR combines these two steps for convenience and to make always doing that less error prone. This will also help me with some of the `tox.ini` refactoring I'm planning to do.

I ran the full test suite on everything and tested the release script changes locally.

This change shouldn't have any effect on cryptography's setup because they install `certbot[test]` which depends on pip, setuptools, and wheel.

* always pipstrap

* use pip_install.py during releases
This commit is contained in:
Brad Warren
2023-04-05 16:43:26 -07:00
committed by GitHub
parent 45327d00c4
commit a78073812c
9 changed files with 39 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
tools/pip_install.py
View File

@@ -1,7 +1,14 @@
#!/usr/bin/env python
# pip installs packages using pinned package versions. If CERTBOT_OLDEST is set
# to 1, tools/oldest_constraints.txt is used, otherwise, tools/requirements.txt
# is used.
# is used. Before installing the requested packages, core Python packaging
# tools like pip, setuptools, and wheel are updated to pinned versions to
# increase stability of the install.
#
# cryptography is currently using this script in their CI at
# https://github.com/pyca/cryptography/blob/14d45c2259b01f1459eeab8bb7d85ce4cfb0841b/.github/downstream.d/certbot.sh#L8-L9.
# We should try to remember to keep their repo updated if we make any changes
# to this script which may break things for them.
from __future__ import absolute_import
from __future__ import print_function
@@ -9,43 +16,52 @@ from __future__ import print_function
import os
import subprocess
import sys
import tempfile
def find_tools_path():
return os.path.dirname(os.path.realpath(__file__))
def call_with_print(command, env=None):
if not env:
env = os.environ
def call_with_print(command, env):
assert env is not None
print(command)
subprocess.check_call(command, shell=True, env=env)
def pip_install_with_print(args_str, env=None):
if not env:
env = os.environ
def pip_install_with_print(args_str, env):
command = ['"', sys.executable, '" -m pip install --disable-pip-version-check ', args_str]
call_with_print(''.join(command), env=env)
def main(args):
def pip_constrained_environ():
tools_path = find_tools_path()
with tempfile.TemporaryDirectory() as working_dir:
repo_path = os.path.dirname(tools_path)
if os.environ.get('CERTBOT_OLDEST') == '1':
constraints_path = os.path.normpath(os.path.join(
repo_path, 'tools', 'oldest_constraints.txt'))
else:
constraints_path = os.path.normpath(os.path.join(
repo_path, 'tools', 'requirements.txt'))
repo_path = os.path.dirname(tools_path)
if os.environ.get('CERTBOT_OLDEST') == '1':
constraints_path = os.path.normpath(os.path.join(
repo_path, 'tools', 'oldest_constraints.txt'))
else:
constraints_path = os.path.normpath(os.path.join(
repo_path, 'tools', 'requirements.txt'))
env = os.environ.copy()
env["PIP_CONSTRAINT"] = constraints_path
env = os.environ.copy()
# We set constraints for pip using an environment variable so that they
# are also used when installing build dependencies. See
# https://github.com/certbot/certbot/pull/8443 for more info.
env["PIP_CONSTRAINT"] = constraints_path
return env
pip_install_with_print(' '.join(args), env=env)
def pipstrap(env=None):
if env is None:
env = pip_constrained_environ()
pip_install_with_print('pip setuptools wheel', env=env)
def main(args):
env = pip_constrained_environ()
pipstrap(env)
pip_install_with_print(' '.join(args), env=env)
if __name__ == '__main__':