From 51a7e7cd1928352a96b6849004e176bbd6cd1863 Mon Sep 17 00:00:00 2001 From: Adrien Ferrand Date: Fri, 17 May 2019 23:50:29 +0200 Subject: [PATCH] Fix unpinned dependencies tests towards botocore and urllib3 (#7081) * Limit transitive dependency on urllib3 to <1.25 to fulfill requirements in certbot-dns-route53 throught botocore dependency. --- certbot-dns-route53/setup.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/certbot-dns-route53/setup.py b/certbot-dns-route53/setup.py index 09cd4acd2..ab9bc4d06 100644 --- a/certbot-dns-route53/setup.py +++ b/certbot-dns-route53/setup.py @@ -6,6 +6,11 @@ version = '0.35.0.dev0' # Remember to update local-oldest-requirements.txt when changing the minimum # acme/certbot version. install_requires = [ + # boto3 requires urllib<1.25 while requests 2.22+ requires urllib<1.26 + # Since pip lacks a real dependency graph resolver, it will peak the constraint only from + # requests, and install urllib==1.25.2. Setting an explicit dependency here solves the issue. + # Check https://github.com/boto/botocore/issues/1733 for resolution in botocore. + 'urllib3<1.25', 'acme>=0.29.0', 'certbot>=0.34.0', 'boto3',